| 15 Oct 2025 |
 Philip Taron (UTC-8) | Modules (the clang impl) works great with C. | 17:56:39 |
| Philip Taron (UTC-8) | Maybe even better than with C++. | 17:56:50 |
| Philip Taron (UTC-8) | Actually, definitely better than with C++. | 17:57:00 |
 fzakaria | how do I go from Store to BinaryCacheStore | 21:55:59 |
| fzakaria | the config only return ref<Store> | 21:56:04 |
| fzakaria | dynamic_pointer_cast? | 21:57:08 |
| fzakaria | Sergei Zimmerman (xokdvium): writing a unit test for that issue you sent me is a bit harder because I think it's S3 specific (needs a store that uses query params)
For now I have https://github.com/NixOS/nix/pull/14266
One option: write a store just for tests that is simiilar to HttpBinaryCacheStore but sends the derivation path as a query parameter to test the encoding?
| 23:37:42 |
 Sergei Zimmerman (xokdvium) | In reply to @fzakaria:one.ems.host
Sergei Zimmerman (xokdvium): writing a unit test for that issue you sent me is a bit harder because I think it's S3 specific (needs a store that uses query params)
For now I have https://github.com/NixOS/nix/pull/14266
One option: write a store just for tests that is simiilar to HttpBinaryCacheStore but sends the derivation path as a query parameter to test the encoding?
The S3 stuff is no longer relying on custom logic (since a couple hours ago) tho | 23:38:32 |
| Sergei Zimmerman (xokdvium) | Did that maybe just fix the issue entirely? | 23:39:01 |
| fzakaria | it might have ; i included some change to src/libstore/binary-cache-store.cc that I think is "correct" but it doesn't have a unit test. | 23:39:42 |
| fzakaria | * it might have | 23:40:47 |
| fzakaria | Anyways; i pushed a unit test... took me a while to right. 🫠| 23:41:05 |
| fzakaria | * Anyways; i pushed a unit test... took me a while to write. 🫠| 23:41:09 |
| fzakaria | What was it before?
I see S3BinaryCacheStoreConfig now | 23:46:43 |
| fzakaria | can you help me figure out what i'm missing to get it to build... it builds locally but not
nix build .#nix-store-tests
| 23:57:57 |
| 16 Oct 2025 |
| Sergei Zimmerman (xokdvium) | In reply to @fzakaria:one.ems.host
can you help me figure out what i'm missing to get it to build... it builds locally but not
nix build .#nix-store-tests
🪵? I can take a look when I get a chance
Anyway it’s way past bed time for me 🛌 | 00:10:13 |
| fzakaria | wow i found it...my nix skills are 13378 | 02:17:00 |
| fzakaria | * wow i found it...my nix skills are 1337 | 02:17:02 |
| fzakaria | hmm Github actions does something else with some wrapper | 02:59:23 |
 Mic92 | We should make a call on https://github.com/NixOS/nix/pull/13971 | 08:07:51 |
 John Ericson | Mic92: I also have some changes to make about how the disabling works that i think will help with that | 14:10:27 |
| John Ericson | Robert Hensing (roberth): I think I am going to try to land your infra improvements (awesome!!) and just the hash change first | 14:12:38 |
 Robert Hensing (roberth) | Ok, awesome. I'd done that kind of thing before, so I'm glad I could help | 14:13:32 |
| Robert Hensing (roberth) | Not sure if separate schema files are the way to go btw. I've only used the doc generation tool with a single schema so far in nixops4 | 14:14:19 |
| Robert Hensing (roberth) | (well, two mostly unrelated schemas) | 14:14:26 |
| John Ericson | yeah was just thinking we might need that | 14:25:36 |
| John Ericson | because of references between then | 14:25:42 |
| John Ericson | but we can wait and see | 14:25:45 |
| Robert Hensing (roberth) | one big schema should also be fine | 14:26:00 |
| Robert Hensing (roberth) | at least for the store layer | 14:26:08 |
