| 26 Mar 2025 |
Shahar "Dawn" Or | Sorry for rubber ducking here | 20:30:16 |
Shahar "Dawn" Or | Here's the reproduction. Should I file an issue?
https://github.com/mightyiam/reproduction-nixos-nix-git-dir-affects-evaluation | 20:53:51 |
Robert Hensing (roberth) | Shahar "Dawn" Or (mightyiam): yes please :) | 21:10:05 |
Shahar "Dawn" Or | https://github.com/NixOS/nix/issues/12762 | 21:23:15 |
John Ericson | emily: We have consensus on your idea for #include "nix/...." | 22:00:20 |
John Ericson | would you be willing to take a stab at implementing that? | 22:00:27 |
emily | I'm probably going to be very busy for the next month or two so I think wouldn't have the time to hack on it :( | 22:24:05 |
emily | I think I outlined basically what I'd do in here before though | 22:24:12 |
John Ericson | emily: fair enough | 22:25:57 |
John Ericson | fs.copyfile right? | 22:26:02 |
emily | right, if you want to synthesize an include/nix in the build directory. though my actual proposal was just to move the files :) | 22:31:48 |
John Ericson | emily: yes moving the files is what i have implemented today | 22:52:16 |
John Ericson | but I sold Eelco on the compromise that you invented :) | 22:52:31 |
| 27 Mar 2025 |
John Ericson | hmm custom targets don't work with install_headers | 00:20:39 |
John Ericson | I think I therefore want to symlnk the headers in the repo | 00:22:25 |
John Ericson | Eelco: is that OK with you? | 00:22:31 |
fzakaria | is there a good link to understand how the outPath is calculated for a drv ? | 02:48:57 |
John Ericson | https://github.com/NixOS/nix/pull/12764 OK it's done (pending CI) | 05:50:17 |
John Ericson | backport to avoid conflicts on other backports? not sure | 05:50:27 |
Robert Hensing (roberth) | these new docs seem relevant https://nix.dev/manual/nix/development/store/derivation/index.html | 10:36:50 |
Robert Hensing (roberth) | also its subpages | 10:36:59 |
emily | In reply to @Ericson2314:matrix.org https://github.com/NixOS/nix/pull/12764 OK it's done (pending CI) seems better to just ignore /libcmd/*.hh etc. rather than having an extra step for every new header | 12:17:07 |
| sinan changed their profile picture. | 13:10:48 |
John Ericson | emily: some libraries do have private headers, however | 14:59:42 |
John Ericson | I would make more of that cleaning up the configuration headers too | 15:00:03 |
John Ericson | * I would make more of them cleaning up the configuration headers too | 15:00:08 |
emily | include-private/? :) | 15:02:27 |
emily | or include/nix-private, avoids setting up another flag | 15:02:43 |
John Ericson | hmm maybe | 15:04:52 |
John Ericson | it is traditional to put the private headers with the source files, but it is also traditional to put the private headers and source files in something like src/ to distinguish from include/ | 15:06:47 |