| 20 Feb 2025 |
John Ericson | emily: you might want to see what nix-eval-jobs and hydra are now doing for 2.26 | 00:29:11 |
John Ericson | yes the config stuff is not yet good by any means | 00:29:24 |
emily | looks like explicit -includes rather than anything in the .pc? https://github.com/NixOS/hydra/blob/18c0d762109549351ecf622cde34514351a72492/meson.build#L22-L26 | 00:30:17 |
John Ericson | yes :* | 00:30:27 |
John Ericson | * yes :( | 00:30:30 |
John Ericson | now that we are more explicit about the configuration variables than with autoconf, I want to only export the ones the headers actualy depend on | 00:31:15 |
John Ericson | (which should be a lot less) | 00:31:21 |
John Ericson | and use regular #include | 00:31:37 |
John Ericson | emily: another thing is I don't know whether #include "foo" or #include <nix/foo> is better within nix itself | 00:34:26 |
John Ericson | the latter violates "don't know your own name" but keeps us dogfooding our headers as others would use them | 00:34:50 |
John Ericson | (the /nix in the pkg-config is definitely bad) | 00:35:04 |
John Ericson | * (the /nix in the *.pc is definitely bad) | 00:35:14 |
emily | I'm honestly surprised if #include "b.h" works to find y/include/foo/b.h from x/include/foo/a.h even if both are on the include path | 00:36:45 |
emily | but if it does then I guess it's fine | 00:36:48 |
John Ericson | I am not sure that works | 00:43:18 |
John Ericson | there is just the sibling even if not in same path rule | 00:43:34 |
John Ericson | * there is just the sibling even if on directly on the path rule | 00:43:44 |
emily | then I'm not sure how ^ ever works | 00:47:10 |
John Ericson | emily: that's because -I.../nix in the pkg-config` | 01:38:14 |
John Ericson | and also the meson build time C flags | 01:38:24 |
John Ericson | * and also the meson when building Nix itself C flags | 01:38:37 |
Mic92 | In reply to @Ericson2314:matrix.org emily: that's because -I.../nix in the pkg-config` Could we not extend cflags in our pc files to include those conf headers? | 02:39:13 |
Mic92 | Than other projects don't need to do the same | 02:39:54 |
Mic92 | * Than other projects don't need anything except for using pc files | 02:41:00 |
Mic92 | I remember having subtle runtime crashes rather than build errors when I did forget one of the includes | 02:42:01 |
flokli | Lovely | 03:23:19 |
John Ericson | Mic92: yeah we can do that | 03:28:00 |
John Ericson | that is definitely better than the status quo | 03:28:06 |
John Ericson | even if it is less than the ideal thing | 03:28:14 |
John Ericson | Eelco: Can you review https://github.com/NixOS/nix/pull/12531 ? | 18:30:20 |