| 26 Sep 2025 |
Taeer Bar-Yam | Yes. It will immediately get garbage collected | 16:56:59 |
John Ericson | OK | 16:57:23 |
Taeer Bar-Yam | probably I could rearrange the commits. I wasn't sure how much effort to put into cleaning up the commit history because i wasn't sure if I should squash them all before merging anyways | 16:57:47 |
Sergei Zimmerman (xokdvium) | In reply to @shine:proqqul.net probably I could rearrange the commits. I wasn't sure how much effort to put into cleaning up the commit history because i wasn't sure if I should squash them all before merging anyways In case the in-between commits are broken then there isn’t much point to keeping those separate. Also the diff is small enough | 16:58:45 |
John Ericson | I don't know how much things can/should be squashed, I'll leave that to sergei :), but yeah anything that will be squashed away of course don't worry about the history | 16:59:06 |
Taeer Bar-Yam | (i'm aware the tests are failing btw. looking into it) | 17:08:46 |
Mic92 | Taeer Bar-Yam: btw. don't mind too much, but in general you can avoid "formatting" commands, by using git-absorb: https://github.com/tummychow/git-absorb | 18:25:51 |
Mic92 | * Taeer Bar-Yam: btw. don't mind too much, but in general you can avoid "formatting" commits, by using git-absorb: https://github.com/tummychow/git-absorb | 18:25:59 |
Taeer Bar-Yam | Ah, thanks for the tip! I'll try to look into it soon. Though I'm kind of wary of stuff that is automagical with my git history 😅 | 20:09:03 |
magic_rb | It says it will only create fixup commits by default so you can review them | 20:10:29 |
Taeer Bar-Yam | oh i see. that's much better | 20:10:55 |