!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

897 Members
For people hacking on the Nix package manager itself191 Servers

Load older messages


SenderMessageTime
20 Feb 2025
@Ericson2314:matrix.orgJohn Ericsonoh woah19:07:29
@Ericson2314:matrix.orgJohn Ericsonok sorry 19:07:34
@Ericson2314:matrix.orgJohn Ericson I didn't know any of the fs.* things were deferred actions 19:07:45
@emilazy:matrix.orgemily so you enumerate (or glob I guess if you have to) the headers from source – that part would be configure time, I suppose – fs.copyfile them to include/nix, and include in the build directory that can be the resulting library's include directory 19:08:16
@Ericson2314:matrix.orgJohn Ericsonwe already don't have glob (RIP)19:08:26
@Ericson2314:matrix.orgJohn Ericsonso making a bunch of separate build targets is OK19:08:35
@emilazy:matrix.orgemilyseems like a silly amount of ceremony but you can probably abstract it into the existing support thing.19:10:33
@emilazy:matrix.orgemily and that at least ensures that downstream code only sees the include/ as it will be installed 19:10:49
@emilazy:matrix.orgemilyregardless of source organization19:10:54
@Ericson2314:matrix.orgJohn Ericsonyes19:10:59
@Ericson2314:matrix.orgJohn Ericson emily: I did the symlink wrong and broke git :D 19:22:37
@emilazy:matrix.orgemilystill don't think you need an in-source symlink at all :P19:23:36
@Ericson2314:matrix.orgJohn EricsonI don't but I think it is an easier first step in some respects19:24:41
@Ericson2314:matrix.orgJohn Ericson * I don't either, but I think it is an easier first step in some respects19:24:46
@emilazy:matrix.orgemily FWIW, from some digging it looks like apparently the requiring -I…/nix thing dates back to 2.19… 19:25:22
@Ericson2314:matrix.orgJohn EricsonI think it is effectively older19:25:44
@Ericson2314:matrix.orgJohn Ericson oh requiring 19:25:49
@Ericson2314:matrix.orgJohn Ericsonsome things came up because unit tests19:25:57
@emilazy:matrix.orgemily if there's already a list of the header files in the source then it's only a few lines of Meson to loop over them to make an include/ in the build directory that can be used for both installation and downstream internal consumers, right? 19:27:07
@Ericson2314:matrix.orgJohn Ericson emily: I got weird enough stuff that I am just moving the files the "normal" way 19:34:09
@roberthensing:matrix.orgRobert Hensing (roberth)clangd might be affected by such a solution, but I don't know that19:44:15
@Ericson2314:matrix.orgJohn Ericson emily: header-file-namespacing branch 22:10:11
@Ericson2314:matrix.orgJohn Ericsonthe bug churn :)22:10:20
@Ericson2314:matrix.orgJohn Ericson * the big churn :)22:10:23
@Ericson2314:matrix.orgJohn Ericson CC ^ Robert Hensing (roberth) 22:10:31
@roberthensing:matrix.orgRobert Hensing (roberth)ooh22:11:56
@roberthensing:matrix.orgRobert Hensing (roberth) github diff 22:12:01
@emilazy:matrix.orgemily looks reasonable to me :) is "nix/…" rather than <nix/…> correct for the installed headers? (also, I think nix/ rather than include/nix/ is still kinda bad because you're still going to be including .cc files etc. in the include path, unless I'm misreading) 22:12:07
@Ericson2314:matrix.orgJohn Ericsonit could be <....>22:12:28
@Ericson2314:matrix.orgJohn Ericsonnot sure!22:12:31

Show newer messages


Back to Room ListRoom Version: 6