| 28 Oct 2025 |
lassulus |  Download image.png | 20:33:05 |
Mic92 | is there anything regarding a "review_status" that you can disable right away? | 20:33:31 |
lassulus |  Download image.png | 20:33:58 |
Mic92 | That one. | 20:34:12 |
Mic92 | Can you turn it off. Maybe also the high-level summary | 20:34:21 |
lassulus | ok, saved it | 20:34:46 |
Mic92 | thanks. | 20:35:02 |
Mic92 | I'll test it | 20:35:10 |
Mic92 | Seems to work:
https://github.com/NixOS/nix/pull/14401 | 20:36:33 |
Mic92 | no. | 20:36:43 |
Mic92 | I'll check if now the yaml overrides it: reviews.review_status | 20:37:22 |
lassulus |  Download image.png | 20:38:14 |
lassulus | this one? | 20:38:15 |
Mic92 | Oh, why is auto-review enabled again :) | 20:38:50 |
lassulus | maybe because we inherited the default settings? | 20:39:21 |
lassulus | disable both? | 20:39:24 |
lassulus | or only the first? | 20:39:27 |
Mic92 | I think we don't need auto reviews. second one can stay. also no " Enable GitHub Checks" | 20:39:49 |
lassulus | ok, done | 20:40:35 |
Mic92 | I'll test again | 20:40:55 |
lassulus | maybe we need similar settings for nix-community :) | 20:40:58 |
Mic92 | I have the feeling that our setting in the webui get overriden by the yaml file now.
Sergei Zimmerman (xokdvium) https://github.com/NixOS/nix/pull/14402 <- tried to add that.
| 20:44:42 |
Mic92 | ah hang on. | 20:45:10 |
Mic92 | schema might be not correct | 20:45:14 |
Mic92 | Otherwise I am also ok, with just having this on my PRs or people that don't mind. | 20:50:28 |
Mic92 | Okay. Looks like the message is gone now: https://github.com/NixOS/nix/pull/14403 | 20:50:41 |
Taeer Bar-Yam | Thanks, yeah. I really appreciate the consideration. We can have a longer conversation about it if you want at some point, but the short version is the further I can be away from this stuff the more comfortable I am. | 20:53:19 |
lovesegfault | Mic92: Does it just take a while? https://github.com/NixOS/nix/pull/14392#issuecomment-3458434057 | 20:55:45 |
Mic92 | so it did | 20:56:58 |
Sergei Zimmerman (xokdvium) | Sorry about this. From my understanding this was only supposed to be a somewhat of a tool in the box for maintainers as a last resort to hopefully catch more bugs before they get merged. This won't be force-fed to anybody -- that's for certain. I won't be using this for example. I've yeeted all the comments from all PRs that I could find. | 20:56:58 |