!VRULIdgoKmKPzJZzjj:nixos.org

Nix Package Manager development

860 Members
For people hacking on Nix: https://github.com/NixOS/nix Nix maintainers can be reached here.185 Servers

Load older messages


SenderMessageTime
28 Oct 2025
@lassulus:lassul.uslassulusimage.png
Download image.png
20:33:05
@joerg:thalheim.ioMic92is there anything regarding a "review_status" that you can disable right away?20:33:31
@lassulus:lassul.uslassulusimage.png
Download image.png
20:33:58
@joerg:thalheim.ioMic92That one.20:34:12
@joerg:thalheim.ioMic92Can you turn it off. Maybe also the high-level summary20:34:21
@lassulus:lassul.uslassulusok, saved it20:34:46
@joerg:thalheim.ioMic92thanks.20:35:02
@joerg:thalheim.ioMic92I'll test it20:35:10
@joerg:thalheim.ioMic92Seems to work: https://github.com/NixOS/nix/pull/1440120:36:33
@joerg:thalheim.ioMic92no.20:36:43
@joerg:thalheim.ioMic92I'll check if now the yaml overrides it: reviews.review_status20:37:22
@lassulus:lassul.uslassulusimage.png
Download image.png
20:38:14
@lassulus:lassul.uslassulusthis one?20:38:15
@joerg:thalheim.ioMic92Oh, why is auto-review enabled again :)20:38:50
@lassulus:lassul.uslassulusmaybe because we inherited the default settings?20:39:21
@lassulus:lassul.uslassulusdisable both?20:39:24
@lassulus:lassul.uslassulusor only the first?20:39:27
@joerg:thalheim.ioMic92I think we don't need auto reviews. second one can stay. also no " Enable GitHub Checks"20:39:49
@lassulus:lassul.uslassulusok, done20:40:35
@joerg:thalheim.ioMic92I'll test again20:40:55
@lassulus:lassul.uslassulusmaybe we need similar settings for nix-community :)20:40:58
@joerg:thalheim.ioMic92

I have the feeling that our setting in the webui get overriden by the yaml file now.

Sergei Zimmerman (xokdvium) https://github.com/NixOS/nix/pull/14402 <- tried to add that.

20:44:42
@joerg:thalheim.ioMic92ah hang on.20:45:10
@joerg:thalheim.ioMic92schema might be not correct20:45:14
@joerg:thalheim.ioMic92Otherwise I am also ok, with just having this on my PRs or people that don't mind.20:50:28
@joerg:thalheim.ioMic92Okay. Looks like the message is gone now: https://github.com/NixOS/nix/pull/1440320:50:41
@shine:proqqul.netTaeer Bar-YamThanks, yeah. I really appreciate the consideration. We can have a longer conversation about it if you want at some point, but the short version is the further I can be away from this stuff the more comfortable I am.20:53:19
@lovesegfault:matrix.orglovesegfault Mic92: Does it just take a while? https://github.com/NixOS/nix/pull/14392#issuecomment-3458434057 20:55:45
@joerg:thalheim.ioMic92so it did20:56:58
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Sorry about this. From my understanding this was only supposed to be a somewhat of a tool in the box for maintainers as a last resort to hopefully catch more bugs before they get merged. This won't be force-fed to anybody -- that's for certain. I won't be using this for example. I've yeeted all the comments from all PRs that I could find.20:56:58

Show newer messages


Back to Room ListRoom Version: 6