| 29 Aug 2025 |
fzakaria |
path.emplace_back("");
| 23:44:52 |
fzakaria | (it was pushing back forward slash before) | 23:45:14 |
John Ericson | give it a pull | 23:48:56 |
fzakaria | oh i was gonan land them ;P | 23:49:11 |
John Ericson | oh sorry | 23:49:22 |
John Ericson | I did that because the initial "" makes an initial / | 23:49:33 |
John Ericson | I get a test failure now | 23:49:56 |
John Ericson | but at least local and CI should agree | 23:50:00 |
fzakaria | from what ? | 23:51:22 |
fzakaria | i thin kits from the new try | 23:52:39 |
fzakaria | parseURL actually parses scp like... | 23:52:50 |
fzakaria | that's why i had the if guard | 23:52:54 |
fzakaria | (it parses it wrong... but it succeeds the parse) | 23:53:07 |
fzakaria | i.e. github.com:/owner/repo.git | 23:53:13 |
fzakaria | (probably another boost bug to open) | 23:53:18 |
fzakaria | k i added those guards back and pushed. | 23:55:38 |
fzakaria | if (auto r = boost::urls::parse_uri(url); r && r->has_scheme() && r->has_authority()) {
return parseURL(url);
}
if (hasPrefix(url, "file:"))
return parseURL(url);
| 23:55:45 |