| 17 Oct 2025 |
raboof | yeah I won't pretend I understand what exactly is going on, just sharing my observation after bisecting :) | 13:45:27 |
John Ericson | raboof: ah OK I think I see what is going on | 15:24:41 |
John Ericson | there is no need to re-register the path info in the check case, but we still want to re-sign it | 15:25:00 |
John Ericson | (assuming it didn't change) | 15:25:05 |
John Ericson | raboof: so a tricky thing with --check is that it doesn't register outputs that were not registered before | 15:46:05 |
John Ericson | I was surprised to learn that, and a few of my refactors were dedicated to making sure I didn't break that | 15:46:47 |
John Ericson | as a I split things up | 15:46:56 |
John Ericson | that is why DerivationBuilder doesn't register or return any path infos in the --check case | 15:47:27 |
John Ericson | and I think it should stay that way | 15:47:30 |
John Ericson | but we can make the caller just look them in the check case just for calling the hook | 15:47:43 |
John Ericson | raboof: https://github.com/NixOS/nix/pull/14289 here's your fix! :) | 17:11:20 |
raboof | Oh cool, thx! s/most/post/ 🙂. Will take it for a spin later this weekend! | 17:50:44 |
fzakaria | Do the VM tests use a different derivation ? | 19:13:39 |
fzakaria | My new test is passing .#componentTests but failing vmTests | 19:14:04 |
fzakaria | I need to add python3 ... hmm;
Not sure why it's not there if it's in the componentTests | 19:16:10 |
fzakaria | (I think I found it -- probably makes more sense to make it propagatedInputs but i just referenced it again) | 19:18:23 |
fzakaria | okay gonna pickup another issue | 19:36:39 |
fzakaria | i hit 60 min timeout on this PR | 20:23:07 |
fzakaria | https://github.com/NixOS/nix/pull/14285 | 20:23:08 |
fzakaria | but its all post tests :( | 20:23:15 |
fzakaria | can someone re-run it ? | 23:18:34 |
| 18 Oct 2025 |
| @ihar.hrachyshka:matrix.org left the room. | 00:11:45 |
| turbio joined the room. | 00:21:51 |
raboof | hmm I seems to remember in the past I seem to remember it would refuse to even start rebuilding in that case, with a message about "some outputs are not valid" or somesuch. I can't reproduce it right now, though, and might be confusing things. | 10:38:56 |
raboof | things like https://cache.nixos.org/5yzw0vhkyszf2d179m0qfkgxmp5wjjx4.narinfo have no deriver but are in the cache anyway... do those ever get fetched? wouldn't they always be present locally because they're created as part of instantiation? | 15:26:14 |
dramforever | you don't have to eval to download stuff from cache.nixos.org, there's nix copy | 15:27:54 |
dramforever | uh, with --substitute-on-destination | 15:28:16 |
dramforever | or you can nix copy --from https://cache.nixos.org a path | 15:28:31 |
dramforever | but the point is no, it won't always be present locally | 15:28:55 |
raboof | right, you can, but I wondered if/when that happens in practice | 15:30:58 |