| 17 Oct 2025 |
 raboof | this is indeed not about 'regular' builds but about rebuilds - filed https://github.com/NixOS/nix/issues/14287 | 07:27:57 |
 Sergei Zimmerman (xokdvium) | In reply to @raboof:matrix.org
this is indeed not about 'regular' builds but about rebuilds - filed https://github.com/NixOS/nix/issues/14287 I think there’s been some changes around builtOutputs that might not keep those for bmCheck mode. | 07:34:33 |
| Sergei Zimmerman (xokdvium) | Must have been the DerivationGoal per-output split | 07:35:13 |
| Sergei Zimmerman (xokdvium) | Or was it called just in the DerivationBuildingGoal? | 07:36:17 |
| raboof | jup indeed looks like it broke in https://github.com/NixOS/nix/pull/13294 | 13:30:15 |
| Sergei Zimmerman (xokdvium) | In reply to @raboof:matrix.org
jup indeed looks like it broke in https://github.com/NixOS/nix/pull/13294 That itself was a fix for checking when not all outputs are valid | 13:38:44 |
| Sergei Zimmerman (xokdvium) | So when some outputs have been substituted previously | 13:39:16 |
| raboof | yeah I won't pretend I understand what exactly is going on, just sharing my observation after bisecting :) | 13:45:27 |
 John Ericson | raboof: ah OK I think I see what is going on | 15:24:41 |
| John Ericson | there is no need to re-register the path info in the check case, but we still want to re-sign it | 15:25:00 |
| John Ericson | (assuming it didn't change) | 15:25:05 |
| John Ericson | raboof: so a tricky thing with --check is that it doesn't register outputs that were not registered before | 15:46:05 |
| John Ericson | I was surprised to learn that, and a few of my refactors were dedicated to making sure I didn't break that | 15:46:47 |
| John Ericson | as a I split things up | 15:46:56 |
| John Ericson | that is why DerivationBuilder doesn't register or return any path infos in the --check case | 15:47:27 |
| John Ericson | and I think it should stay that way | 15:47:30 |
| John Ericson | but we can make the caller just look them in the check case just for calling the hook | 15:47:43 |
| John Ericson | raboof: https://github.com/NixOS/nix/pull/14289 here's your fix! :) | 17:11:20 |
| raboof | Oh cool, thx! s/most/post/ 🙂. Will take it for a spin later this weekend! | 17:50:44 |
 fzakaria | Do the VM tests use a different derivation ? | 19:13:39 |
| fzakaria | My new test is passing .#componentTests but failing vmTests | 19:14:04 |
| fzakaria | I need to add python3 ... hmm;
Not sure why it's not there if it's in the componentTests | 19:16:10 |
| fzakaria | (I think I found it -- probably makes more sense to make it propagatedInputs but i just referenced it again) | 19:18:23 |
| fzakaria | okay gonna pickup another issue | 19:36:39 |
| fzakaria | i hit 60 min timeout on this PR | 20:23:07 |
| fzakaria | https://github.com/NixOS/nix/pull/14285 | 20:23:08 |
| fzakaria | but its all post tests :( | 20:23:15 |
| fzakaria | can someone re-run it ? | 23:18:34 |
| 18 Oct 2025 |
|  @ihar.hrachyshka:matrix.org left the room. | 00:11:45 |
|  turbio joined the room. | 00:21:51 |
