7 Oct 2025 |
lovesegfault | the variant testing we can revert | 21:10:59 |
Sergei Zimmerman (xokdvium) | I'm very much in favor of running tests/builds for s3 store. We just shouldn't have 2 new matrices for this and even more copy-pasta | 21:13:41 |
Sergei Zimmerman (xokdvium) | If we could just add the vm tests to regular tests and add a new config to build with the new s3 that'd be great | 21:14:15 |
Sergei Zimmerman (xokdvium) | Then we'd get the benefit of running vm tests with sanitizers as well | 21:14:49 |
lovesegfault | 🫠| 21:14:53 |
lovesegfault | i won't have time to do that for a while, and i'm spending too much time on this curl work as it is | 21:15:39 |
Sergei Zimmerman (xokdvium) | Sure, I had a draft branch for the cleanup. I wasn't suggesting you needed to tackle that | 21:17:51 |
lovesegfault | can you point me to that? | 21:18:32 |
Sergei Zimmerman (xokdvium) | Don't think I've pushed it anywhere yet | 21:19:01 |
Philip Taron (UTC-8) | I'll get a PR spun up for Nixpkgs | 21:24:38 |
Sergei Zimmerman (xokdvium) | Thanks! There's some flags you'll need to yeet to not tank performance | 21:27:06 |
Sergei Zimmerman (xokdvium) | https://github.com/NixOS/nix/pull/14105/commits/c1f805b8569d1f66aed813a3b49820936618c9d5 | 21:27:24 |
Philip Taron (UTC-8) | Is that suitable for all Nix versions, or just 2.32? | 21:28:04 |
Philip Taron (UTC-8) | It's a bit hard to apply that solely to Nix 2.32, so I think it'll get applied to even stable. | 21:32:13 |
Sergei Zimmerman (xokdvium) | I'm not sure it's safe to apply to other nix versions tbh. I've run into unfortunate UB that this surfaced. I'd gate this for 2.32 and upwards | 21:34:16 |
Sergei Zimmerman (xokdvium) | Mic92: Now that we have the backport action what's the next steps for github merge queues? Org issue? | 21:43:37 |
Philip Taron (UTC-8) | https://github.com/NixOS/nixpkgs/pull/449668 | 21:52:34 |
lovesegfault | Sergei Zimmerman (xokdvium): can you elaborate on the ci improvements you'd like to see? | 23:31:02 |
Sergei Zimmerman (xokdvium) | Well, first it'd be nice if vm_tests were just part of tests . I've already done the refactor to make the nixos tests accept nixComponents. There we can enable s3-binary-cache-store test + evalNixpkgs | 23:32:20 |
Sergei Zimmerman (xokdvium) | cc getchoo | 23:32:35 |
lovesegfault | okay, let me see what i can do | 23:35:28 |
lovesegfault | i don't want to be blocked on ci for the s3 work to land | 23:35:37 |
lovesegfault | i need to be done with this stuff, it's been almost two months | 23:36:08 |
Sergei Zimmerman (xokdvium) | Yeah sure, let me see what we can do about enabling your work | 23:36:08 |
lovesegfault | i'm worried shifting prios at work will force me to just drop it entirely, which would be a shame | 23:36:38 |
lovesegfault | for me at least, i've loved working on this stuff | 23:36:45 |
Sergei Zimmerman (xokdvium) | Eh, I guess we can go ahead and clean that up later :) | 23:36:47 |
lovesegfault | i'll time box fixing ci to tonight | 23:37:10 |
lovesegfault | but let me give it a shot at least | 23:37:30 |
lovesegfault | i want to leave things better than i found them | 23:37:36 |