| 8 Oct 2025 |
Mic92 | https://github.com/NixOS/nix/actions/runs/18333686106/job/52213704796?pr=14187#step:8:28 yet another unwrapped std::filesystem exception. | 06:33:49 |
lovesegfault | alright, with the CI changes done i've rebased the next little bit of the s3 work and it's ready for review: https://github.com/NixOS/nix/pull/14170 | 15:12:13 |
lovesegfault | we're almost there now 🥳 | 15:12:59 |
| siraben joined the room. | 15:25:02 |
siraben | Looking to gauge interest in the ability to break a nix store lock manually, what do people think?
https://github.com/NixOS/nix/pull/13813 revisiting this PR right now | 15:25:17 |
| frontear joined the room. | 15:36:50 |
lovesegfault | John Ericson: i saw your review comments on #14170 just now, but i don't get the motivation? why introduce this usernameAuth stuff? | 15:45:23 |
lovesegfault | are you thinking that something else will leverage that later? | 15:45:42 |
John Ericson | lovesegfault: yes, something else might leverage it later, and also just trying to reduce the mount of stuff we have under the S3 ifdef | 15:46:14 |
John Ericson | fwiw at Nix Con I thought Jane Street people mentioned they needed auth for ldap too | 15:46:56 |
John Ericson | so that is a second use-case right there | 15:47:11 |
John Ericson | lovesegfault: if you do manage to make my acceptions go, I would PR username auth first, before the current PR, if it is not to hard to write an integration test which tests it | 15:50:16 |
John Ericson | * lovesegfault: if you do manage to make my suggested changes work, I would PR username auth first, before the current PR, if it is not to hard to write an integration test which tests it | 15:50:41 |
John Ericson | (but also can wait for someone else, e.g. Sergei Zimmerman (xokdvium) to weigh in first, and establish it's not just me thinking these things :)) | 15:51:29 |
lovesegfault | i don't see how I could possibly test it? | 18:33:59 |
lovesegfault | unless you want me to expose username/password in the store config? | 18:34:11 |
lovesegfault | John Ericson: here you go https://github.com/NixOS/nix/pull/14190 | 18:40:48 |
John Ericson | (sorry just saw, will be in meeting today) | 18:41:13 |
John Ericson | will look at PR | 18:41:30 |
John Ericson | we have done _NIX_TEST env var hacks to help with integration testing before | 18:41:40 |
John Ericson | so we could set admin:their-password that way or somthing, just spit-balling | 18:42:06 |
lovesegfault | i mean, it will get tested as the curl-s3 work lands | 19:04:13 |
lovesegfault | and if it's not working, i'll be forced to fix it to make the s3 tests pass | 19:04:27 |
lovesegfault | so i'd argue that it lands even without tests right now as it will get tests in the next couple carve-outs | 19:04:54 |
John Ericson | Redacted or Malformed Event | 19:59:10 |
| tavinator joined the room. | 22:36:39 |
| 9 Oct 2025 |
| chipre joined the room. | 01:39:53 |
lovesegfault | next bit of the s3 work: https://github.com/NixOS/nix/pull/14198 | 02:45:49 |
lovesegfault | we're getting close! | 02:46:07 |
lovesegfault | once the above land, next steps:
- all builtin fetchurl pre-resolution stuff
- add the s3 test suite
- switch the default
- remove the legacy impl
| 02:59:24 |