| 8 Dec 2025 |
Sergei Zimmerman (xokdvium) | Specifically this:
std::string localPath = url.substr(7);
+ if (!std::filesystem::exists(localPath)) {
+ throw Error("tarball '%s' does not exist.", localPath);
+ }
| 12:38:59 |
Sergei Zimmerman (xokdvium) | Basically it will fail shamefully when encountering a symbol that gets pct-encoded in the file:// URL and barf early even though the later fetching code does the decoding correctly and since NIX_BUILD_TOP is in a dir that has + in it... | 12:41:56 |
dramforever | oooh this is why it only fails if no sandbox | 12:43:24 |
Sergei Zimmerman (xokdvium) | Yup... | 12:43:39 |
dramforever | oh | 12:46:04 |
dramforever | duh | 12:46:07 |
dramforever | i was trying to --no-sandbox and i don't think that does anything... | 12:46:20 |
dramforever | probably for the better | 12:46:34 |
dramforever | this is fixed but it's so un-cherry-pick-able | 13:02:48 |
dramforever | there's like a whole new url parsing infrastructure thing added on | 13:03:08 |
Sergei Zimmerman (xokdvium) | Yeah, I know. Probably just doing a percentDecode on the localPath would be enough | 13:03:42 |
dramforever | update on that is i just realized i can repro this locally on linux if i just do sandbox = false | 16:43:58 |
dramforever | so i'm running a build with this patch https://github.com/NixOS/nix/pull/14734 | 16:44:11 |
dramforever | hopefully that would fix it | 16:44:30 |
Mic92 | John Ericson: looks like there is some issue now when using the current stable nix against a new nix daemon?
clan-env % nix develop
path '/home/joerg/git/clan-core/pkgs/clan-cli' does not contain a 'flake.nix', searching up
error:
… while checking derivation '/nix/store/v8qnm8aabm0fp0v2xf3cavsgwqfgc2bk-clan-env.drv'
error: derivation has incorrect deferred output, should be '/nix/store/jq6nq5bvdv23xdjajsaj2ay6vni5bkki-clan-env'
clan-env % real-which nix
/nix/store/ah8kqqslr7jig18fd4hzmdk2bhbqs8a7-nix-2.31.2/bin/nix
clan-env % /nix/store/7ykgjirdiwxkdwyh3hypd27ifx7aws29-nix-2.33.0pre20251208_5b5d4cb/bin/nix develop
path '/home/joerg/git/clan-core/pkgs/clan-cli' does not contain a 'flake.nix', [joerg@eve clan-cli]$
| 16:50:58 |
dramforever | nevermind | 17:01:56 |
dramforever | the tests just fail on linux without sandbox... | 17:02:15 |