| 29 Aug 2025 |
 fzakaria |
path.emplace_back("");
| 23:44:52 |
| fzakaria | (it was pushing back forward slash before) | 23:45:14 |
 John Ericson | give it a pull | 23:48:56 |
| fzakaria | oh i was gonan land them ;P | 23:49:11 |
| John Ericson | oh sorry | 23:49:22 |
| John Ericson | I did that because the initial "" makes an initial / | 23:49:33 |
| John Ericson | I get a test failure now | 23:49:56 |
| John Ericson | but at least local and CI should agree | 23:50:00 |
| fzakaria | from what ? | 23:51:22 |
| fzakaria | i thin kits from the new try | 23:52:39 |
| fzakaria | parseURL actually parses scp like... | 23:52:50 |
| fzakaria | that's why i had the if guard | 23:52:54 |
| fzakaria | (it parses it wrong... but it succeeds the parse) | 23:53:07 |
| fzakaria | i.e. github.com:/owner/repo.git | 23:53:13 |
| fzakaria | (probably another boost bug to open) | 23:53:18 |
| fzakaria | k i added those guards back and pushed. | 23:55:38 |
| fzakaria | if (auto r = boost::urls::parse_uri(url); r && r->has_scheme() && r->has_authority()) {
return parseURL(url);
}
if (hasPrefix(url, "file:"))
return parseURL(url);
| 23:55:45 |
| 30 Aug 2025 |
| John Ericson | we should not use two UIR parsers | 00:01:46 |
| John Ericson | if we need to check schem and authority | 00:01:55 |
| John Ericson | we can do it on our parseURL | 00:01:59 |
| fzakaria | gonna make dinner; put a comment on the PR | 00:02:50 |
| fzakaria | and i'll follow up on it | 00:02:52 |
| fzakaria | 👍️ | 00:02:56 |
| fzakaria | * gonna make dinner; put a comment on the PR please | 00:03:02 |
| fzakaria | I think boost and parseURL are too lenient though and scp style are making it through | 00:04:57 |
| fzakaria | saw your comment. | 00:05:27 |
| John Ericson | cool | 00:19:23 |
| John Ericson | and sorry I had missed your comments | 00:19:28 |
 tsn9cp_again | Quick question about the naming convention of package/derivation versions in Nix:
If I build from a specific commit, which is present only in a specific branch, how would I name the version? AFAIK the convention for non-tagged commit on the main branch is "unstable-YYYY-MM-DD". Where would the branch fit into this? | 10:36:37 |
 K900 | Better question for #Nixpkgs / NixOS contributions | 10:37:11 |
