29 Aug 2025 |
| kdeuser joined the room. | 17:38:47 |
| magic_rb changed their profile picture. | 19:27:19 |
John Ericson | ahhh i have many builder goal cleanup commits :) | 19:57:13 |
John Ericson | the knot is unravelling fast!@ | 19:57:19 |
John Ericson | * the knot is unravelling fast! | 19:57:21 |
fzakaria | msut be from the merge it's failing | 23:34:34 |
fzakaria | the branch for me also passes. | 23:34:38 |
fzakaria | i'll rebase from master. | 23:34:41 |
fzakaria | hmm rebase also passes. | 23:35:30 |
fzakaria | maybe John Ericson you'll know why... lol | 23:40:25 |
John Ericson | fzakaria: I dunno! | 23:40:50 |
John Ericson | I guess a bad thing with string_view | 23:41:00 |
John Ericson | ubsan | 23:41:27 |
fzakaria | oh you went back to string_view | 23:41:29 |
John Ericson | Sergei Zimmerman (xokdvium): is loking | 23:41:34 |
fzakaria | yea that's bad, clangd is giving me the warning | 23:41:39 |
fzakaria | wait is it... | 23:41:48 |
fzakaria |
Clang-Tidy: Std::move of the const variable 'path' of the trivially-copyable type 'const std::basic_string_view<char>' has no effect; remove std::move()
| 23:41:51 |
fzakaria | i get bitten too much by rvalue and string_view... i thought it was such a cool feature | 23:42:35 |
fzakaria | and now i ignore it | 23:42:38 |
John Ericson | yeah the std::move can go goes it's trivially coppiable | 23:42:57 |
fzakaria | i learned about some hack that the compiler does for rvalues that are also created as function variables to make their lifetime expended. | 23:43:01 |
fzakaria | expanded* | 23:43:13 |
fzakaria | i see this | 23:43:32 |
fzakaria |
Clang-Tidy: Std::basic_string_view outlives its value
| 23:43:33 |
fzakaria |
Clangd: Object backing the pointer 'modifiedUrl' will be destroyed at the end of the full-expression
| 23:43:43 |
John Ericson | ah yeah | 23:44:04 |
John Ericson | I only did one of the two path prefix thinggies | 23:44:12 |
John Ericson | I didn't see the other | 23:44:14 |
fzakaria | why did you chang eit to push back empty string? | 23:44:50 |