18 Jul 2025 |
fzakaria | sure; still better than current model. You can special case the 10% rather than give up on the 90% | 15:08:38 |
Mic92 | In reply to @fzakaria:one.ems.host sweet -- the IWYU is what i'm really after. You mean the clang-tidy one? Works quite well on nix-eval-jobs | 17:33:14 |
Mic92 | In reply to @qyliss:fairydust.space IWYU is difficult for portable programs like Nix Maybe that can be enabled somehow for nix header only? | 17:34:34 |
Mic92 | Same actually for platform specific header - could be a bit tedious though | 17:35:25 |
Mic92 | @xokdvium:matrix.org: clang format stuff is good to go? | 17:36:58 |
Sergei Zimmerman (xokdvium) | I think so. The diff is good and the auto-rebase script seems to work well. | 17:37:33 |
Mic92 | Okay. Hit it! | 17:38:04 |
Sergei Zimmerman (xokdvium) | Done! No more range formatting. Yay! | 17:40:50 |
Sergei Zimmerman (xokdvium) | Pinned an issue about the auto-rebase script: https://github.com/NixOS/nix/issues/13502 | 18:02:18 |
connor (he/him) (UTC-7) | I know that one of the expensive parts of CI with Nix monorepos is evaluation on each commit in part because there's no re-use of evaluation caches across commits.
I see that a new AttrDb is created for each fingerprint (https://github.com/NixOS/nix/blob/b8d223a2106c7dbdb0c61f822288195ee9e26e9b/src/libexpr/eval-cache.cc#L75).
For those with knowledge about evaluation caching as it is currently implemented: would it be feasible to rewrite it such that entries in Attributes use the hash of their source files as part of their primary key?
As an example, if the hashes of the files read to evaluate an attribute doesn't change across two commits, the result from the first evaluation would be returned for the second (it would be cached). | 22:05:10 |
| andiandi@hadr25 🏰🏞️ changed their display name from andiandi 🦆 to andiandi@hadr25. | 22:09:06 |
| andiandi@hadr25 🏰🏞️ changed their display name from andiandi@hadr25 to andiandi@hadr25 🏰🏞️. | 22:13:42 |