| 7 Oct 2025 |
 lovesegfault | btw, does this help with perf concerns? https://github.com/NixOS/nix/pull/14171/files#diff-d6730623c42446aa1f33e3177f7146d342ca8d5103e0814bb0b7ac212af5576dR90-R99 | 23:41:43 |
| lovesegfault | idk if the str scan is fast enough to help | 23:41:54 |
 Sergei Zimmerman (xokdvium) | I was thinking that we could just special-case '.' and '..': '.' does nothing and '..' does a pop. Also I don't think the rhs of this operator is ever supposed to have a '/' there | 23:43:07 |
| Sergei Zimmerman (xokdvium) | I see you've added the tests for such cases, but isn't that supposed to be handled by CanonPath::extend? | 23:45:46 |
| Sergei Zimmerman (xokdvium) | There's the comment:
/**
* Add a path component to this one. It must not contain any slashes.
*/
| 23:46:27 |
| Sergei Zimmerman (xokdvium) | Maybe the right thing is to instead fix the user code? | 23:46:38 |
| lovesegfault | i wasn't sure what could end up there realistically, just wanted to avoid having that weird assert thrown at users | 23:46:50 |
| lovesegfault | yeah, okay, maybe we only handle dots | 23:46:57 |
