| 7 Oct 2025 |
 Sergei Zimmerman (xokdvium) | https://github.com/NixOS/nix/pull/14105/commits/c1f805b8569d1f66aed813a3b49820936618c9d5 | 21:27:24 |
 Philip Taron (UTC-8) | Is that suitable for all Nix versions, or just 2.32? | 21:28:04 |
| Philip Taron (UTC-8) | It's a bit hard to apply that solely to Nix 2.32, so I think it'll get applied to even stable. | 21:32:13 |
| Sergei Zimmerman (xokdvium) | I'm not sure it's safe to apply to other nix versions tbh. I've run into unfortunate UB that this surfaced. I'd gate this for 2.32 and upwards | 21:34:16 |
| Sergei Zimmerman (xokdvium) | Mic92: Now that we have the backport action what's the next steps for github merge queues? Org issue? | 21:43:37 |
| Philip Taron (UTC-8) | https://github.com/NixOS/nixpkgs/pull/449668 | 21:52:34 |
 lovesegfault | Sergei Zimmerman (xokdvium): can you elaborate on the ci improvements you'd like to see? | 23:31:02 |
| Sergei Zimmerman (xokdvium) | Well, first it'd be nice if vm_tests were just part of tests. I've already done the refactor to make the nixos tests accept nixComponents. There we can enable s3-binary-cache-store test + evalNixpkgs | 23:32:20 |
| Sergei Zimmerman (xokdvium) | cc getchoo | 23:32:35 |
| lovesegfault | okay, let me see what i can do | 23:35:28 |
| lovesegfault | i don't want to be blocked on ci for the s3 work to land | 23:35:37 |
| lovesegfault | i need to be done with this stuff, it's been almost two months | 23:36:08 |
| Sergei Zimmerman (xokdvium) | Yeah sure, let me see what we can do about enabling your work | 23:36:08 |
| lovesegfault | i'm worried shifting prios at work will force me to just drop it entirely, which would be a shame | 23:36:38 |
| lovesegfault | for me at least, i've loved working on this stuff | 23:36:45 |
| Sergei Zimmerman (xokdvium) | Eh, I guess we can go ahead and clean that up later :) | 23:36:47 |
| lovesegfault | i'll time box fixing ci to tonight | 23:37:10 |
| lovesegfault | but let me give it a shot at least | 23:37:30 |
| lovesegfault | i want to leave things better than i found them | 23:37:36 |
| Sergei Zimmerman (xokdvium) | Merged for now :) Sorry for being a pain. We can do incremental improvements | 23:39:11 |
| lovesegfault | not a pain at all, i share your goals and concerns here :) | 23:39:31 |
| lovesegfault | btw, does this help with perf concerns? https://github.com/NixOS/nix/pull/14171/files#diff-d6730623c42446aa1f33e3177f7146d342ca8d5103e0814bb0b7ac212af5576dR90-R99 | 23:41:43 |
| lovesegfault | idk if the str scan is fast enough to help | 23:41:54 |
| Sergei Zimmerman (xokdvium) | I was thinking that we could just special-case '.' and '..': '.' does nothing and '..' does a pop. Also I don't think the rhs of this operator is ever supposed to have a '/' there | 23:43:07 |
| Sergei Zimmerman (xokdvium) | I see you've added the tests for such cases, but isn't that supposed to be handled by CanonPath::extend? | 23:45:46 |
| Sergei Zimmerman (xokdvium) | There's the comment:
/**
* Add a path component to this one. It must not contain any slashes.
*/
| 23:46:27 |
| Sergei Zimmerman (xokdvium) | Maybe the right thing is to instead fix the user code? | 23:46:38 |
| lovesegfault | i wasn't sure what could end up there realistically, just wanted to avoid having that weird assert thrown at users | 23:46:50 |
| lovesegfault | yeah, okay, maybe we only handle dots | 23:46:57 |
|  @adam:robins.wtf left the room. | 23:48:18 |
