| 7 Oct 2021 |
 niksnut | Sure, I can do a release | 15:04:16 |
| niksnut | In reply to @andi:kack.it
Before diving into doing the change I had a thought yesterday while looking at related code: Any reason we don't implement Expr{Sub,Add,...} like we do for ExprNotOp etc? In the case of subtraction it could get rid of about 30k Symbol table looks, a few thousand new objects (while building a NixOS test). And execution wouldn't probably do a few less function calls. That would probably break overriding substraction by providing a __sub (or whatever) function in the current scope (if that even works right now). No, I think the reason it's implemented that way is because builtins.sub etc. already existed | 15:14:19 |
 andi- | In reply to @niksnut:matrix.org
No, I think the reason it's implemented that way is because builtins.sub etc. already existed Would you see any downside to adding those implementations? I could have a go on the in one of the coming evenings.
I don't think that it will improve performance by a lot but I also haven't measured the time spent in those functions. I was just surprised that IIRC the sub primop was the most used one (by a few 10k) when I did eval a NixOS VM test.
| 15:16:49 |
| niksnut | The only downside is that it's a bit more code | 15:17:36 |
 tomberek | musl issue is related to: 4993174 | 15:19:43 |
| niksnut | In reply to @niksnut:matrix.org
Sure, I can do a release 2.3.16 is up | 15:36:21 |
| niksnut | In reply to @tomberek:matrix.org
musl issue is related to: 4993174 Okay, we could revert that | 15:37:09 |
 baloo | niksnut: thank you so much! | 15:54:59 |
| niksnut | I've created a 2.4-maintenance branch and a hydra jobset | 15:57:10 |
| niksnut | I'll do a rc1 release for testing | 15:57:19 |
| baloo | @niksnut I've pushed the nix bump on https://github.com/NixOS/nixpkgs/pull/137197 Is that alright? or do you want to split in another PR? | 16:08:15 |
| baloo | it adds a nixos integration tests, that checks the nss preload works as expected | 16:08:55 |
| niksnut | maybe it's better to add the test to nix rather than nixos | 16:09:43 |
| baloo | is there any qemu based test infrasture in nix? | 16:10:31 |
| baloo | * is there any qemu based test infrastructure in nix? | 16:10:47 |
| baloo | because I really have no idea how to test this expect the way I implemented it with 2 vms | 16:11:18 |
| baloo | (or two namespaces would work too) | 16:11:43 |
| niksnut | yes, we have several NixOS VM tests in the nix repo | 16:12:00 |
| niksnut | like tests.githubFlakes | 16:12:20 |
| niksnut | the question is really whether this test serves more as a regression test for nix or for nixos | 16:12:46 |
| niksnut | if this is something that can break in nix, the test should be in the nix repo ideally | 16:13:06 |
| baloo | this is definitely better suited in nix itself | 16:13:24 |
| niksnut | example: https://github.com/NixOS/nix/blob/master/tests/remote-builds.nix | 16:13:47 |
| baloo | ha, I was still on the 2.3 branch >< | 16:15:09 |
| baloo | https://github.com/NixOS/nixpkgs/pull/140868 for the nix2.3 bump | 16:20:42 |
| baloo | and https://github.com/NixOS/nix/pull/5351 Thanks for pointing out the integration tests in nix. | 17:56:04 |
| niksnut | Hm, aarch static build still fails: https://hydra.nixos.org/eval/1711612#tabs-still-fail | 18:34:16 |
| niksnut | I uploaded nix-2.4pre-rc1: https://releases.nixos.org/?prefix=nix/nix-2.4pre-rc1 | 19:39:28 |
| tomberek | I'm trying to track down the static build problem. | 19:44:17 |
| tomberek | trofi: can you look at #5350, i'm trying to figure out what went wrong | 21:14:41 |
