| 7 Oct 2025 |
lovesegfault | okay, 2.32 is branched off, version has been bumped, can someone hit merge on https://github.com/NixOS/nix/pull/14147 for me now? | 21:07:29 |
lovesegfault | * okay, 2.32 is branched off, version has been bumped, can someone hit merge on https://github.com/NixOS/nix/pull/14147 for me? | 21:07:34 |
Sergei Zimmerman (xokdvium) | I really wish we could clean github actions before doing this | 21:07:59 |
Sergei Zimmerman (xokdvium) | Now they are a total mess | 21:08:08 |
Sergei Zimmerman (xokdvium) | Like vm tests should just be part of regular tests | 21:08:38 |
lovesegfault | my hope is that change is just reverted after we're done churning this code | 21:08:45 |
Sergei Zimmerman (xokdvium) | But also you are not running s3 tests in ci anyway? | 21:08:55 |
Sergei Zimmerman (xokdvium) | I'd hope that it's not. We just should run vm/s3 tests all the time | 21:09:29 |
lovesegfault | anyway, the main benefit is that in while we work on s3 you don't have to trust me that i tested that it still builds with s3 disabled or with the legacy s3 enabled :P | 21:10:51 |
lovesegfault | the variant testing we can revert | 21:10:59 |
Sergei Zimmerman (xokdvium) | I'm very much in favor of running tests/builds for s3 store. We just shouldn't have 2 new matrices for this and even more copy-pasta | 21:13:41 |
Sergei Zimmerman (xokdvium) | If we could just add the vm tests to regular tests and add a new config to build with the new s3 that'd be great | 21:14:15 |
Sergei Zimmerman (xokdvium) | Then we'd get the benefit of running vm tests with sanitizers as well | 21:14:49 |