!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

994 Members
For people hacking on the Nix package manager itself210 Servers

Load older messages


SenderMessageTime
20 Sep 2021
@roberthensing:matrix.orgRobert Hensing (roberth)(I mean any C++ code we wrote, not the security almost-term "arbitrary code")12:26:39
@derkha:matrix.orgKha Does Nix even use more than that single coroutine in serialise.cc, which does not have a nested yield? In any case, afaiui you cannot have directly yield from inside a nested call with these coroutines, but you can yield to the surrounding coroutine, which then yields to the caller/next coroutine, etc. 12:34:20
@derkha:matrix.orgKha It's like Python before yield from 12:34:31
@derkha:matrix.orgKha * Does Nix even use more than that single coroutine in serialise.cc, which does not have a nested yield? In any case, afaiui you cannot directly yield from inside a nested call with these coroutines, but you can yield to the surrounding coroutine, which then yields to the caller/next coroutine, etc. 12:35:06
@derkha:matrix.orgKhaThere is absolutely no stack pointer manipulation with this approach12:35:38
@cw:kernelpanic.cafeRev. CornWallace III (novus ordo seclorum) changed their display name from Rev. CornWallace III to Rev. CornWallace III (tzu/tzi).15:22:23
@cw:kernelpanic.cafeRev. CornWallace III (novus ordo seclorum) changed their display name from Rev. CornWallace III (tzu/tzi) to Rev. CornWallace III (sun/tzu).15:24:44
@roberthensing:matrix.orgRobert Hensing (roberth) Kha: I'm going to trust you on that 15:29:53
@roberthensing:matrix.orgRobert Hensing (roberth)A possible issue is that these coroutines are "viral" in the sense that any stack frame between coroutine start and yield must become part of the coroutine. Some of these are virtual method invocations and some might be calls into libraries we don't control (not sure)15:31:42
@roberthensing:matrix.orgRobert Hensing (roberth)So those are possible challenges. I would really like for this to work and I suspect that C++20 may be a nicer requirement than boost_context, although I'm blissfully unaware of C++20 maturity15:33:08
@roberthensing:matrix.orgRobert Hensing (roberth)You could give it a try15:34:26
@derkha:matrix.orgKhaIt does sound fun. But to be honest, if that one tiny function really remains the only use of coroutines since it was introduced 3 years ago, I feel like the only reasonable approach is to replace it with a hand-written state machine :) . I might try that one first.15:46:05
@roberthensing:matrix.orgRobert Hensing (roberth) That includes such a code transformation on the nar parser and the Store interface for adding directories to the store with an arbitrary filter function, among potentially other things 16:47:28
@roberthensing:matrix.orgRobert Hensing (roberth)an async or state machine style nar parser will improve memory consumption in one case iirc, so that alone may be worth it16:48:16
@trofi:matrix.orgtrofi

nix build parallelism question: it looks like currently nix tries very hard to download everything from internet before attempting the build for things that certainly don't have binary substitutions.

Does nix have a knob (or could it be tweaked?) to start first required build sooner to get final result faster? It's a bit odd to see 3 hours if prerequisite download and 2 hours of actual build time. Example current state:

[0/2091 built, 16/898/1354 copied (9886.6/14818.7 MiB), 4775.8/6830.3 MiB DL] fetching source from https://cache.nixos.org

17:50:31
21 Sep 2021
@timdeh:matrix.orgnrdxp joined the room.14:49:28
@Las:matrix.orgLas I'm probably missing something obvious, but I can't use recursive nix even with recursive-nix in my experimental-features in /etc/nix/nix.conf. It only works if I use single-user mode by specifying a store with --store. 19:14:22
@Las:matrix.orgLas Nevermind, I can't get it to work at all. I get /nix/var: Permission denied when running nix build. 19:32:26
@Las:matrix.orgLas I fixed my issue: It has to be in system-features too... 20:05:48
22 Sep 2021
@derkha:matrix.orgKha
In reply to @trofi:matrix.org

nix build parallelism question: it looks like currently nix tries very hard to download everything from internet before attempting the build for things that certainly don't have binary substitutions.

Does nix have a knob (or could it be tweaked?) to start first required build sooner to get final result faster? It's a bit odd to see 3 hours if prerequisite download and 2 hours of actual build time. Example current state:

[0/2091 built, 16/898/1354 copied (9886.6/14818.7 MiB), 4775.8/6830.3 MiB DL] fetching source from https://cache.nixos.org

AFAIR this is because substitution and building uses a common work queue constrained by max-jobs. If they used independent (and ideally differently-sized) pools, building might be able to start sooner.
09:19:56
@derkha:matrix.orgKha
In reply to @trofi:matrix.org

nix build parallelism question: it looks like currently nix tries very hard to download everything from internet before attempting the build for things that certainly don't have binary substitutions.

Does nix have a knob (or could it be tweaked?) to start first required build sooner to get final result faster? It's a bit odd to see 3 hours if prerequisite download and 2 hours of actual build time. Example current state:

[0/2091 built, 16/898/1354 copied (9886.6/14818.7 MiB), 4775.8/6830.3 MiB DL] fetching source from https://cache.nixos.org

* AFAIR this is because substitution and building use a common work queue constrained by max-jobs. If they used independent (and ideally differently-sized) pools, building might be able to start sooner.
09:20:06
23 Sep 2021
@tazjin:matrix.orgtazjin joined the room.14:51:43
24 Sep 2021
@cw:kernelpanic.cafeRev. CornWallace III (novus ordo seclorum) changed their display name from Rev. CornWallace III (sun/tzu) to Rev. CornWallace III (novus ordo seclorum).01:01:26
@enterprisey:matrix.orgenterprisey joined the room.04:58:06
25 Sep 2021
@derkha:matrix.orgKha Robert Hensing (roberth): Ah, now I get it. The single place where coroutines are used in Nix is in decompression via libarchive, to convert between the non-blocking Sink "push" model used everywhere else and the Source "pull" model because libarchive does not have a non-blocking API. Yikes. 09:20:32
@roberthensing:matrix.orgRobert Hensing (roberth)we do have some internal use as well, but this kind of forces us to use stackful coroutines09:24:51
@roberthensing:matrix.orgRobert Hensing (roberth)threads could be an alternative. On disk buffering probably not desirable 09:26:57
@derkha:matrix.orgKha Ah right, I missed that the other direction, sinkToSource, uses it as well. Which is used, err, everyhwere. 09:29:27
@derkha:matrix.orgKha * Ah right, I missed that the other direction, sinkToSource, uses coroutines as well. Which is used, err, everyhwere. 09:29:36
@roberthensing:matrix.orgRobert Hensing (roberth)mostly because nar parsing is pull based I believe09:31:18

Show newer messages


Back to Room ListRoom Version: 6