| 19 Jan 2026 |
infinisil | Yeah exactly | 16:52:45 |
infinisil | I don't think that's a problem if it's opt-in. You can decide how the tree-structure should look like with how you write Nix code | 16:53:37 |
Sergei Zimmerman (xokdvium) | Hm the stack usage is already unbounded, but that could make the situation even worse. I couldn’t really come up with a good algorithm for doing m-way merges with a binary tree that’s a bounded in stack usage | 16:54:20 |
Sergei Zimmerman (xokdvium) | That’s why I went with a linked list for the structural sharing PR (don’t know if you saw that or not) | 16:54:44 |
infinisil | (didn't see it) | 16:55:00 |
Sergei Zimmerman (xokdvium) | https://github.com/NixOS/nix/pull/13987
That reduced nixpkgs-metrics memory usage from 27 GB to ~ 20GB | 16:56:04 |
Sergei Zimmerman (xokdvium) | I really wanted to do a binary tree, but the on-demand m-way merge got a lot in the way | 16:56:47 |
Robert Hensing (roberth) | work sesh about to start btw. I'll join after/with some food | 16:59:20 |
Sergei Zimmerman (xokdvium) | In reply to @roberthensing:matrix.org work sesh about to start btw. I'll join after/with some food Can’t make it today. Would be very happy if you’ll had a chance to do one more pass on the ssh-ng:// coroutine perf fix in https://github.com/NixOS/nix/pull/14998 | 17:00:53 |
Sergei Zimmerman (xokdvium) | In reply to @roberthensing:matrix.org work sesh about to start btw. I'll join after/with some food * Can’t make it today. Would be very happy if you all had a chance to do one more pass on the ssh-ng:// coroutine perf fix in https://github.com/NixOS/nix/pull/14998 | 17:01:04 |
niksnut | left a comment | 17:22:38 |
Sergei Zimmerman (xokdvium) | In reply to @niksnut:matrix.org left a comment Addressed! Much simpler now | 20:33:09 |