| 17 Oct 2024 |
 hexa | and now the proposal is to just ship protobuf | 15:47:28 |
| hexa | * we had buildPackages.protobuf before | 15:47:34 |
| hexa | make the call 🙂 | 15:47:51 |
| hexa | we need the protoc executable available for consumers | 15:48:07 |
 Artturin | https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/top-level/python-packages.nix#L10715
https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/top-level/python-packages.nix#L10720
Change these to pkgs.__splicedPackages.X and it'll work
| 15:50:04 |
| Artturin | * https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/top-level/python-packages.nix#L10715
https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/top-level/python-packages.nix#L10720
Change these to pkgs.__splicedPackages.X and it'll work without buildPackages.
| 15:50:15 |
| hexa | what the fresh hell is __splicedPackages now 😄 | 15:50:52 |
| Artturin | If we want to do it automagically we can pass pkgs = pkgs.__splicedPackages here https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/development/interpreters/python/passthrufun.nix#L39 | 15:51:06 |
| Artturin | In reply to @hexa:lossy.network
what the fresh hell is __splicedPackages now 😄 It's just contains the packages with __spliced | 15:51:27 |
| hexa | by all means, lets make it more magical | 15:51:30 |
| Artturin | pkgs isn't __splicedPackages
callPackage gets from __splicedPackages https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/top-level/splice.nix#L140-L144 | 15:52:18 |
 emily | maybe just buildPackages is better | 15:52:36 |
| hexa | In reply to @artturin:matrix.org
If we want to do it automagically we can pass pkgs = pkgs.__splicedPackages here https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/development/interpreters/python/passthrufun.nix#L39 why not this? | 15:53:02 |
| emily | i understand one of them 🤪 | 15:53:29 |
| emily | well. i've deluded myself into believing i understand one of them | 15:53:40 |
| hexa | Understanding cross is probably easy if someone who understands it sits down with you | 15:54:19 |
| emily | I think I understand cross okay, but I definitely don't understand splicing. | 15:55:08 |
| Artturin | It's not that bad, the bad part is getting it to work everywhere | 15:56:07 |
| Artturin | with overrides and such | 15:56:21 |
| Artturin | https://github.com/NixOS/nixpkgs/pull/349316 | 16:13:52 |
| hexa | the big hammer | 16:15:23 |
| Artturin | In reply to @artturin:matrix.org
If we want to do it automagically we can pass pkgs = pkgs.__splicedPackages here https://github.com/NixOS/nixpkgs/blob/b88b49c98470a3daf7c09d200777e1c1a1bc2494/pkgs/development/interpreters/python/passthrufun.nix#L39 Oh yeah this is what I've done in perl https://github.com/NixOS/nixpkgs/blob/d2bd9a39dec88eddd5c192abee69939e67f43d12/pkgs/development/interpreters/perl/default.nix#L25 | 16:17:56 |
 dish [Fox/It/She] | Submitted the pytest-cov PR | 16:40:49 |
| dish [Fox/It/She] | https://github.com/nixos/nixpkgs/pull/349324 | 16:41:00 |
| dish [Fox/It/She] | * Submitted the pytest-cov PR, it's targeting staging because of the number of rebuilds | 16:41:16 |
| dish [Fox/It/She] | gonna do the same for codecov-python and actually drop that as well as it's archived. | 16:43:03 |
 kjeremy | It looks like lcov-cobertura is missing distutils at runtime | 17:29:39 |
|  bendlas changed their profile picture. | 17:37:52 |
| kjeremy | I don't really know python but this seems to fix it: https://github.com/NixOS/nixpkgs/pull/349333 | 17:57:57 |
 Gaétan Lepage | In reply to @k900:0upti.me
As long as you merge it reasonably quickly Could someone have a quick look maybe ? So that we can merge it soon.
https://github.com/NixOS/nixpkgs/pull/349270 | 19:48:23 |
