| 12 Jan 2024 |
natsukium | I looked into this issue and could only find that something in the jupyterlab 4.0.6 -> 4.0.7 broke the nixpkgs notebook shortcut(Up/Down).
I can't see the same regression in jupyterlab or nbclassic.
But I'm not interested in pursuing this issue any further.
I tried the pre-release jupyterlab 4.1.0b0 on Ubuntu and macOS, but this version does not provide such shortcuts at all. | 08:59:37 |
p14 | In reply to @natsukium:matrix.org
I'm still not sure what's causing the problem. git bisect says this commit caused it.
first bad commit: [39bd27fd2e71dbcf87efdb675500496fa3cd2633] python311Packages.jupyterlab: 4.0.6 -> 4.0.9
Thanks for the bisect, I can reproduce 39bd27fd2e71dbcf87efdb675500496fa3cd2633 as the first bad commit.
I can further elaborate that the issue appears between 4.0.6 and 4.0.7. I did that by taking that bad commit and overriding the src to acquire the 4.0.7 wheel.
| 15:11:27 |
p14 | So I tried to bisect jupyterlab, but that was a bit of a waste of time because it just points at the commit where all the typescript dependencies got bumped in the package.json: https://github.com/jupyterlab/jupyterlab/commit/fa7fb591e8654ae446998a588d067841e375c542
Does anyone understand how jupyter is put together and if it's possible to properly bisect the changes to it? I assume those things do live within the github:jupyterlab/jupyterlab repo and it should be bisectable... | 15:42:52 |
p14 | Well, I was able to build specific commits of jupyterlab. And specific commits of jupyter notebook. However, I can't seem to build a specific commit of notebook whose dependency is a specific commit of jupyterlab yet. | 16:44:08 |
p14 | I don't understand how notebook picks up the javascript dependencies from jupyterlab. | 16:44:38 |
p14 | In reply to @thomasjm:matrix.org your diagnosis sounds right. could you file a Nixpkgs issue and tag the Jupyter team? https://github.com/NixOS/nixpkgs/issues/280539
I tried for a couple of hours to figure out how to bisect jupyterlab-as-a-dependency-of-jupyter-notebook-in-developer-mode but didn't succeed unfortunately. Bisecting it as an ordinary dependency doesn't work because it just picks up the versions encoded in the package.json when they're eventually bumped.
| 17:00:26 |
| 18 Jan 2024 |
| @fizihcyst:matrix.org joined the room. | 16:58:08 |
| 24 Jan 2024 |
| @nick4f42:matrix.org joined the room. | 02:56:14 |
teto | thomasjm: sry I haven't been able to answer, pretty busy start of the year. Will try to do in upcoming days | 11:56:04 |
@thomasjm:matrix.org | no problem, take your time | 12:20:06 |
| 15 Feb 2024 |
| kenji joined the room. | 19:15:15 |
| 14 Mar 2024 |
| NixOS Moderation Botchanged room power levels. | 18:44:27 |
| 15 Mar 2024 |
| spacesbot - keeps a log of public NixOS channels joined the room. | 04:06:29 |
| spacesbot - keeps a log of public NixOS channels | 05:00:26 |
| 17 Mar 2024 |
| Felipe Marcelino joined the room. | 17:58:19 |
| 19 Mar 2024 |
| NixOS Moderation Botchanged room power levels. | 00:29:53 |
| 21 Mar 2024 |
| NixOS Moderation Botchanged room power levels. | 18:02:50 |
| samasaur joined the room. | 22:42:27 |
samasaur | Has anyone had any success getting Jupyter to recognize python-lsp-server? | 22:43:15 |
| 23 Mar 2024 |
| SomeoneSerge (UTC+U[-12,12]) changed their display name from SomeoneSerge (hash-versioned python modules when) to SomeoneSerge (migrating synapse). | 02:10:54 |
| 8 Apr 2024 |
| l0b0 joined the room. | 00:54:13 |
| 9 Apr 2024 |
| SomeoneSerge (UTC+U[-12,12]) changed their display name from SomeoneSerge (migrating synapse) to SomeoneSerge (void). | 13:24:47 |
| 16 Apr 2024 |
| thoth joined the room. | 09:02:18 |
| 25 Apr 2024 |
| SomeoneSerge (UTC+U[-12,12]) changed their display name from SomeoneSerge (void) to SomeoneSerge (UTC+1). | 23:01:38 |
| 26 Apr 2024 |
| thomaslepoix joined the room. | 14:15:40 |
| 29 Apr 2024 |
| SomeoneSerge (UTC+U[-12,12]) changed their display name from SomeoneSerge (UTC+1) to SomeoneSerge (is taking time off and doesn't want to hear about it). | 11:43:07 |
| NixOS Moderation Botchanged room power levels. | 15:28:31 |
| 1 May 2024 |
| NixOS Moderation Botchanged room power levels. | 15:06:05 |
| 4 May 2024 |
| SomeoneSerge (UTC+U[-12,12]) changed their display name from SomeoneSerge (is taking time off and doesn't want to hear about it) to SomeoneSerge (Way down Hadestown). | 21:03:43 |
| 8 May 2024 |
| checooh joined the room. | 11:58:51 |