| 11 Oct 2024 |
 Alyssa Ross | I have the patch with backports ready to go — I just wanted to check if it was the right thing to do first :) | 07:20:53 |
| Alyssa Ross | PRed | 07:25:07 |
 Jan Tojnar | In reply to @qyliss:fairydust.space
PRed thanks. Will take a look after work | 08:38:26 |
|  dotphem joined the room. | 13:18:38 |
| Alyssa Ross | K900are the comments on https://github.com/NixOS/nixpkgs/pull/347743 saying that I should not do it / do something else?
| 15:49:53 |
 K900 | Not really no | 15:52:26 |
| K900 | It's just kinda cursed | 15:52:34 |
| K900 | But if that's how upstream does things, then what can you do really | 15:52:43 |
| K900 | Actually maybe we should have a comment about the cursedness | 15:52:51 |
| Alyssa Ross | yeah, can do | 15:53:00 |
| K900 | Because at a glance it makes no fucking sense | 15:53:02 |
| K900 | Also yeah consider me fine with any of those related PRs | 15:53:43 |
| K900 | My brain is a bit too cooked to review them right now | 15:53:51 |
| K900 | Or rather to keep track of them | 15:53:56 |
| Alyssa Ross | I'm a bit worried that this'll be one of those things that occur repeatedly, and then need to be commented every time | 15:54:22 |
| K900 | Do you mean the udev thing? | 15:56:22 |
| Alyssa Ross | yeah | 15:56:42 |
| K900 | Maybe we should just stick a passthru.rulesPath or passthru.supportsRules on the udev package then | 15:56:56 |
| Alyssa Ross | hmm | 15:57:07 |
| Alyssa Ross | I guess we can cross that bridge if we come to it | 15:57:19 |
| Alyssa Ross | I added a comment. It's difficult to fully explain this succintly but hopefully it's good enough. | 15:57:54 |
| K900 | Also something is telling me most things will just hardcode $prefix/lib/udev anyway | 15:58:01 |
| Alyssa Ross | unfortunately not | 15:58:10 |
| K900 | Or $prefix/etc/udev | 15:58:14 |
| Alyssa Ross | IME | 15:58:16 |
| Alyssa Ross | but they do often provide an option, and only check for udev.pc if the option is not provided | 15:58:31 |
| Alyssa Ross | and in lots of cases we're already setting that option, so there's nothing to do | 15:59:01 |
| Alyssa Ross | systemd.pc / libsystemd.pc is the same distinction btw | 15:59:27 |
| Alyssa Ross | renaming the udev attribute to libudev for consistentcy might also make things mildly less confusing | 16:01:17 |
| 12 Oct 2024 |
| Alyssa Ross | Jan Tojnarcould I get your review on https://github.com/NixOS/nixpkgs/pull/347803? I'm waiting to merge them all at once since they all rebuild basically the same stuff
| 13:41:57 |
