| 14 Jul 2021 |
 Jan Tojnar | piegames: I would still want to split the extensionRenames into more sections | 00:41:59 |
| Jan Tojnar | since the comment is confusing as is | 00:42:06 |
 piegames | Okay. What sections? | 00:42:14 |
| Jan Tojnar | I mean the comment about gradually automating | 00:42:34 |
| piegames | Should these sections be syntactically be represented in Nix or would some more aggressive formatting suffice? | 00:42:53 |
| Jan Tojnar | the section below it mixes already automated with the three or so manual packages | 00:43:04 |
| Jan Tojnar | just formatting and comment should be enough IMO | 00:43:20 |
| Jan Tojnar | piegames: Something like "These are manually packaged extensions that have different attribute name from the slug on the extension portal." | 00:44:01 |
| Jan Tojnar | And would drop the "gradually being replaced by automatic packaging where possible" part since it contradicts the past tense of "were manually packaged" IIUC | 00:45:33 |
| Jan Tojnar | piegames: also I am confused by paperwm | 00:52:09 |
| piegames | Same | 00:52:14 |
| Jan Tojnar | you have it in automatically packaged section but it is not on the portal? | 00:52:28 |
| Jan Tojnar | should not it be in the manual section then? | 00:52:46 |
| piegames | Yeah, I think the commit dropping the manual packaging was a mistake and should be dropped | 00:54:42 |
| piegames | It's a lot of repetitive work and I do really silly mistakes :/ | 00:55:18 |
| Jan Tojnar | well, now the rest of the code does not count with the removed packages so I would probably just reinstate the paperwm expression | 00:58:11 |
| Jan Tojnar | hopefully, that will not be too much work | 00:58:26 |
| piegames | Already pushed. I just hope I haven't forgotten any of the changes | 00:58:57 |
| Jan Tojnar | This one is still there https://github.com/NixOS/nixpkgs/pull/124315/files#r669203034 | 01:03:01 |
| Jan Tojnar | piegames: otherwise it looks to me fine once the fixup commits are squashed | 01:03:34 |
| piegames | Yeah I just noticed too that I totally forgot about that one | 01:03:51 |
| piegames | Now some of your comments make a lot more sense ^^ | 01:04:00 |
| piegames | In reply to @jtojnar:matrix.org
piegames: otherwise it looks to me fine once the fixup commits are squashed Any whishes regarding commit history cleanup? | 01:04:58 |
| Jan Tojnar | looks reasonably granular to me | 01:06:01 |
| Jan Tojnar | though I guess the removals should come before the other changes | 01:06:57 |
| Jan Tojnar | since the removed expressions do not have the changes made to them | 01:07:17 |
| Jan Tojnar | hmm, they actually remove the lines in changed manuallyPackaged.nix | 01:09:09 |
| Jan Tojnar | that makes it awkward | 01:09:16 |
| piegames | Exactly. I'll see what I can do | 01:09:34 |
| piegames | Jan Tojnar: Please have a look if this is okay. Technically, the order is inconsistent, but at least there is no squash conflict anymore. | 01:25:29 |
