| 29 Nov 2023 |
 infinisil | lennart: Is there a PR? | 11:17:18 |
 lennart | In reply to @infinisil:matrix.org
lennart: Is there a PR? There are several commits to alejandrosame's nixpkgs repo, we will be doing a PR in around 4hrs to NixOS/nixpkgs. | 11:18:01 |
| infinisil | If you don't mind getting some feedback, I'd appreciate a draft PR :) | 11:18:35 |
| lennart | I guess this is not the most beautiful way to do, but right now it's important do finalize… | 11:18:36 |
| lennart | In reply to @infinisil:matrix.org
If you don't mind getting some feedback, I'd appreciate a draft PR :) Not that simply possible since Alejandro split it into several files… | 11:19:08 |
| lennart | He should be awake real soon, maybe we can do it earlier for feedback. | 11:19:54 |
| infinisil | Ah I see it's https://github.com/alejandrosame/nixpkgs/tree/rl-2311-editorial-changes | 11:20:40 |
| lennart | Jub, on mobile right now, wanted to link it soon | 11:21:00 |
 hexa | note that the release notes need to pass through nixos/release-23.11 before the homepage can be updated to deliver them | 13:08:45 |
| lennart | yea | 13:08:56 |
| lennart | currently I can't do anything but wait for Alejandro | 13:13:00 |
 @alejandrosame:matrix.org | I'll push a draft PR within the next hour. | 13:58:54 |
| lennart | awesome | 14:08:03 |
| lennart | you've seen my two PRs? | 14:08:14 |
| lennart | https://github.com/alejandrosame/nixpkgs/pull/10 https://github.com/alejandrosame/nixpkgs/pull/11 | 14:08:31 |
| @alejandrosame:matrix.org | figsoda: raitobezarius lennart infinisil: draft PR is up https://github.com/NixOS/nixpkgs/pull/270959 | 15:22:27 |
|  Clumsily6239 joined the room. | 15:38:04 |
| @alejandrosame:matrix.org | I just did a rebase to fix the merge conflict and GitHub shows the PR as being automerged. I'm confused. | 15:44:17 |
 Lily Foster | In reply to @alejandrosame:matrix.org
I just did a rebase to fix the merge conflict and GitHub shows the PR as being automerged. I'm confused. you probably accidentally rebased it to the base branch with no commits on top | 15:44:55 |
| @alejandrosame:matrix.org | meh, that's odd, my branch had a commit adding the changes in a new commit and that commit didn't stay on top. I'll just remake the PR so this one can be reverted. | 15:54:42 |
| @alejandrosame:matrix.org | * meh, that's odd, my branch had the changes in a new commit and that commit didn't stay on top. I'll just remake the PR so this one can be reverted. | 15:54:55 |
| Lily Foster | In reply to @alejandrosame:matrix.org
meh, that's odd, my branch had the changes in a new commit and that commit didn't stay on top. I'll just remake the PR so this one can be reverted. is there anything to revert? | 15:55:26 |
 @julienmalka:matrix.org | In reply to @alejandrosame:matrix.org
I just did a rebase to fix the merge conflict and GitHub shows the PR as being automerged. I'm confused. Yeah github does that when the PR is empty, that's annoying | 15:56:44 |
| @julienmalka:matrix.org | You probably messed up your rebase somehow | 15:57:21 |
| @alejandrosame:matrix.org | The intention was to make it a draft for last minute feedback, it's just the release notes so not huge deal. I'm just annoyed. | 15:57:23 |
| @alejandrosame:matrix.org | They can still be ammended, I guess I'll wait for the meeting :( | 15:57:47 |
| @alejandrosame:matrix.org | * They can still be ammended, I guess I'll wait for the meeting :) | 15:57:53 |
| @julienmalka:matrix.org | The PR is empty though, nothing to revert just open another one | 15:57:55 |
| @julienmalka:matrix.org | You just merged nothing in master | 15:58:23 |
| @alejandrosame:matrix.org | ah. wth, ok | 15:58:32 |
