!aGqRytqbCECitOFhbt:nixos.org

Release Management

340 Members
25.11 "Xantusia" | https://nixos.github.io/release-wiki/Home.html93 Servers

Load older messages


SenderMessageTime
1 Dec 2023
@lily:lily.flowersLily Foster
In reply to @julienmalka:matrix.org
Is that really the right change ? Is there not a json file somewhere to edit
i mean the flake lock is technically a json file that was edited (i am meaning this as a light-hearted joke, to be clear)
15:38:38
@julienmalka:matrix.org@julienmalka:matrix.org To be clear what I meant was 15:39:02
@julienmalka:matrix.org@julienmalka:matrix.orgIs there not a something something to edit ?15:39:11
@figsoda:matrix.orgfigsoda changed the room topic to "23.11 "Tapir" | https://nixos.github.io/release-wiki/Home.html" from "23.05 "Stoat" | https://nixos.github.io/release-wiki/Home.html".15:39:54
@kranzes:matrix.orgIlan Joselevich (Kranzes)Maybe update room's picture too?18:05:04
Room Avatar Renderer.19:17:09
2 Dec 2023
@julienmalka:matrix.org@julienmalka:matrix.org

Hello, I was discussing the other day with one of my advisors (Théo Zimmermann, who is a nixpkgs committer but not present here) about the difficulties we had for the release process this time, and he suggested a few improvements:

  1. During the branch-off, instead of doing changes to the release-branch, pushing and then also doing modifications to the master branch, he suggested we first open a PR to the master branch containing all the changes described in the Back on the master branch section of the wiki. This can be done before the branch-off and kept as a draft. At the branch-off, we first merge that PR, then we can work on the release branch in peace, knowing exactly on which commit basing this branch. This way we ditch all the problems of the type "the master branch advanced while we were working on the release branch". We also do not have to push on master.
  2. He suggested that instead of using the branch protections feature, we switch to "branch rules". Apparently, they are more expressive than the branch protections, and also appear publicly on the repo: https://github.com/NixOS/nixpkgs/branches --> by going to that page and clicking on the little shield, you get a list of all the rules applying to the branch
13:16:32
@julienmalka:matrix.org@julienmalka:matrix.org *

Hello, I was discussing the other day with one of my advisors (Théo Zimmermann, who is a nixpkgs committer but not present here. He has been a release manager for the Coq project) about the difficulties we had for the release process this time, and he suggested a few improvements:

  1. During the branch-off, instead of doing changes to the release-branch, pushing and then also doing modifications to the master branch, he suggested we first open a PR to the master branch containing all the changes described in the Back on the master branch section of the wiki. This can be done before the branch-off and kept as a draft. At the branch-off, we first merge that PR, then we can work on the release branch in peace, knowing exactly on which commit basing this branch. This way we ditch all the problems of the type "the master branch advanced while we were working on the release branch". We also do not have to push on master.
  2. He suggested that instead of using the branch protections feature, we switch to "branch rules". Apparently, they are more expressive than the branch protections, and also appear publicly on the repo: https://github.com/NixOS/nixpkgs/branches --> by going to that page and clicking on the little shield, you get a list of all the rules applying to the branch
13:17:12
@julienmalka:matrix.org@julienmalka:matrix.org *

Hello, I was discussing the other day with one of my advisors (Théo Zimmermann, who is a nixpkgs committer but not present here. He has been a release manager for the Coq project) about the difficulties we had for the release process this time, and he suggested a few improvements:

  1. During the branch-off, instead of doing changes to the release-branch, pushing and then also doing modifications to the master branch, he suggested we first open a PR to the master branch containing all the changes described in the Back on the master branch section of the wiki. This can be done before the branch-off and kept as a draft. At the branch-off, we first merge that PR, then we can work on the release branch in peace, knowing exactly on which commit to base this branch. This way we ditch all the problems of the type "the master branch advanced while we were working on the release branch". We also do not have to push on master.
  2. He suggested that instead of using the branch protections feature, we switch to "branch rules". Apparently, they are more expressive than the branch protections, and also appear publicly on the repo: https://github.com/NixOS/nixpkgs/branches --> by going to that page and clicking on the little shield, you get a list of all the rules applying to the branch
13:17:43
@raitobezarius:matrix.orgraitobezariusCan you send PRs to the release wiki?14:41:19
@raitobezarius:matrix.orgraitobezariusFor the suggestion 2, this has to be seen with the GH org owners14:41:33
@julienmalka:matrix.org@julienmalka:matrix.orgI can do that yes, wondering if people had feedback on these before I write a PR14:41:49
@raitobezarius:matrix.orgraitobezariusWell, 1 has been suggested multiple times but what matters is the detail of what you will wrote in the release wiki and if this is equivalent to the process we have or do we lose things by doing it this way14:42:10
@raitobezarius:matrix.orgraitobezariusinfinisil did already suggest something similar to 1 (or even exactly 1) in the past but the PR is stalled because my comments about the various edgecases are not addressed yet.14:42:29
@julienmalka:matrix.org@julienmalka:matrix.org
In reply to @raitobezarius:matrix.org
For the suggestion 2, this has to be seen with the GH org owners
Sure, I don't know what is the most appropriate public place is to discuss that
14:42:29
@raitobezarius:matrix.orgraitobezariusHere is probably fine but you need to @ a GH org owner14:42:42
@julienmalka:matrix.org@julienmalka:matrix.org
In reply to @raitobezarius:matrix.org
infinisil did already suggest something similar to 1 (or even exactly 1) in the past but the PR is stalled because my comments about the various edgecases are not addressed yet.
I'll read the PR, thanks
14:43:18
@hexa:lossy.networkhexapublic rules sounds like an improvement15:13:49
@hexa:lossy.networkhexaespecially if they are more granular15:14:01
@infinisil:matrix.orginfinisilIt's a fairly new github feature, I think it was in beta like a year ago15:14:52
@infinisil:matrix.orginfinisilFully agreed that branch rules are better and we should switch to using them15:15:15
3 Dec 2023
@jonringer:matrix.orgjonringerThe manual still needs to be updated with the release date: https://nixos.org/manual/nixos/stable/release-notes#sec-release-23.1118:52:02
@jonringer:matrix.orgjonringer

Release 23.11 (“Tapir”, 2023.11/??)

18:52:21
@vcunat:matrix.orgVladimír ČunátIt's there, only lockfile needs updating: https://github.com/NixOS/nixos-homepage/pull/117720:49:40
4 Dec 2023
@lennart:0520.chlennartI do not really understand, what action is stopping us from having an up-to-date manual15:15:01
@lennart:0520.chlennart * I do not really understand, what action is stopping us from having an up-to-date manual? :)15:15:04
@vcunat:matrix.orgVladimír ČunátI think none of us have permission to merge in the homepage repo. (I don't at least.)15:46:01
@lennart:0520.chlennartI'll poke grahamc and garbas15:48:15
@kranzes:matrix.orgIlan Joselevich (Kranzes)I can16:17:08
@kranzes:matrix.orgIlan Joselevich (Kranzes)What needs to be merged?16:17:23

Show newer messages


Back to Room ListRoom Version: 6