!aGqRytqbCECitOFhbt:nixos.org

Release Management

343 Members
25.11 "Xantusia" | https://nixos.github.io/release-wiki/Home.html93 Servers

Load older messages


SenderMessageTime
20 Nov 2023
@raitobezarius:matrix.orgraitobezariusIt's a change that has to be discussed beforehand and merged before a release process starts20:29:48
@raitobezarius:matrix.orgraitobezariusWe tried multiple minor modifications of the workflow during the branch-off to no avail because of the permissions set currently20:30:04
@infinisil:matrix.orginfinisil
In reply to @raitobezarius:matrix.org
Yep but PR workflow is not a minor change.
It sounds fairly minor to me 🤷
20:32:24
@raitobezarius:matrix.orgraitobezariusSure, it didn't sound minor at that time to me, it doesn't sound minor neither for now20:32:43
@infinisil:matrix.orginfinisilLike, instead of pushing the beta commit directly in the initial branch version, make a PR for that instead, this way you can force push to the PR to update it as necessary20:33:00
@raitobezarius:matrix.orgraitobezariusThe problem is not really in how many ways we can describe this workflow, it is that it's not on the release wiki as clear instructions for release managers20:33:27
@raitobezarius:matrix.orgraitobezariusThis is a process documentation problem, not a process in itself problem20:33:35
@raitobezarius:matrix.orgraitobezariusIf you follow a certain process documentation, you cannot switch to a different type in the middle20:33:45
@raitobezarius:matrix.orgraitobezariusThe whole process has to be written taking into account the new type of workflow you are doing20:33:54
@raitobezarius:matrix.orgraitobezariusAs this is not the case for the time being, this is not a minor change because you can find yourself in the middle of an incompatible step20:34:05
@julienmalka:matrix.org@julienmalka:matrix.org Why did we not test the workflow changes before ? 20:34:08
@raitobezarius:matrix.orgraitobezarius
In reply to @julienmalka:matrix.org
Why did we not test the workflow changes before ?
Because we don't have access to the permission data of the GitHub repository
20:34:20
@raitobezarius:matrix.orgraitobezariusSo we cannot replicate the process on another "test" repo20:34:28
@raitobezarius:matrix.orgraitobezariusWe would have to do it live20:34:32
@julienmalka:matrix.org@julienmalka:matrix.org Yes 20:34:37
@julienmalka:matrix.org@julienmalka:matrix.org Is that not fine ? 20:34:43
@julienmalka:matrix.org@julienmalka:matrix.orgTrying to force push on a random test branch ?20:34:59
@raitobezarius:matrix.orgraitobezariusI would rather avoid polluting the GitHub itself with test data20:34:59
@raitobezarius:matrix.orgraitobezarius * I would rather avoid polluting the GitHub repo itself with test data20:35:05
@raitobezarius:matrix.orgraitobezariusPeople often pull regularly nixpkgs with all the references20:35:12
@raitobezarius:matrix.orgraitobezariusThey would grab the test data refs & git objects20:35:20
@raitobezarius:matrix.orgraitobezarius(People also complain about that)20:35:24
@raitobezarius:matrix.orgraitobezariusAlso, we need to name that branch a certain name to test it20:35:52
@raitobezarius:matrix.orgraitobezariusWe cannot name it "random" branch because not all the branches are protected20:36:00
@raitobezarius:matrix.orgraitobezarius So we would need to do release-TEST_DONOTUSE and test there for example 20:36:16
@infinisil:matrix.orginfinisilHow about figuring this out now, so that we can write down what works for the next release?20:37:15
@raitobezarius:matrix.orgraitobezarius I am not figuring this out, I am tired and this release cycle has been taking a lot of energy of myself, we had a lot of things to deal with and I would like to move any discussion regarding how to improve the release process to the retrospective that is dedicated to this type of issues 20:37:47
@raitobezarius:matrix.orgraitobezarius * I am not figuring this out now, I am tired and this release cycle has been taking a lot of energy of myself, we had a lot of things to deal with and I would like to move any discussion regarding how to improve the release process to the retrospective that is dedicated to this type of issues 20:37:51
@raitobezarius:matrix.orgraitobezariusPeople are free to prepare solutions for the problem but I honestly don't have it in me to plug on my brain to follow such a discussion now20:38:25
@infinisil:matrix.orginfinisilFair enough, thanks for the work! And sorry for being part of the reason for breaking the process 😅20:38:44

Show newer messages


Back to Room ListRoom Version: 6