!aGqRytqbCECitOFhbt:nixos.org

Release Management

343 Members
25.11 "Xantusia" | https://nixos.github.io/release-wiki/Home.html93 Servers

Load older messages


SenderMessageTime
17 Nov 2023
@vcunat:matrix.orgVladimír Čunát (I guess we should create staging-23.11 soon.) 06:18:11
@vcunat:matrix.orgVladimír Čunát * (I guess we should create staging-23.11 soon, as a target for PRs.) 06:18:27
@raitobezarius:matrix.orgraitobezariusFWIW, https://github.com/NixOS/nixpkgs/pull/26764013:52:34
@raitobezarius:matrix.orgraitobezariusI don't like this13:52:37
@raitobezarius:matrix.orgraitobezarius bendlas: My PR will soon go out 14:34:04
@raitobezarius:matrix.orgraitobezariusI'm almost done with backward compat fixes14:34:14
@bendlas:matrix.orgbendlasthe postgres one?14:34:29
@raitobezarius:matrix.orgraitobezariusyep14:34:42
@bendlas:matrix.orgbendlascool, yeah, I think the doc update should also be good to go14:35:16
@raitobezarius:matrix.orgraitobezariusperfect14:36:33
@raitobezarius:matrix.orgraitobezariusoh ffs… https://github.com/iv-org/invidious/blob/c5b87e3b5e5cc7f7f5c8baa7732bd6d81d8f910a/src/invidious/database/migrations/0001_create_channels_table.cr#L714:44:41
@raitobezarius:matrix.orgraitobezariusI am having doubts if using explicitly the schema for creating tables can mess up our strategies or not14:46:20
@bendlas:matrix.orgbendlas you mean the public. prefix? 14:47:07
@raitobezarius:matrix.orgraitobezariusyep14:47:29
@bendlas:matrix.orgbendlaswhat would be the problem there, if we're the owner?14:47:37
@raitobezarius:matrix.orgraitobezarius
    # TODO(raitobezarius to maintainers of invidious): I strongly advise to clean up the kemal specific
    # thing for 24.05 and use `ensureDBOwnership`.
    # See https://github.com/NixOS/nixpkgs/issues/216989
    systemd.services.postgresql.postStart = lib.mkAfter ''
      $PSQL -tAc 'ALTER DATABASE "${cfg.settings.db.dbname}" OWNER TO "${cfg.settings.db.user}";'
      $PSQL -tAc 'GRANT USAGE, CREATE ON SCHEMA public TO "${cfg.settings.db.user}";'
    '';
    services.postgresql = {
      enable = true;
      ensureUsers = lib.singleton { name = cfg.settings.db.user; };
      ensureDatabases = lib.singleton cfg.settings.db.dbname;
      # This is only needed because the unix user invidious isn't the same as
      # the database user. This tells postgres to map one to the other.
      identMap = ''
        invidious invidious ${cfg.settings.db.user}
      '';
      # And this specifically enables peer authentication for only this
      # database, which allows passwordless authentication over the postgres
      # unix socket for the user map given above.
      authentication = ''
        local ${cfg.settings.db.dbname} ${cfg.settings.db.user} peer map=invidious
      '';
    };


14:47:48
@raitobezarius:matrix.orgraitobezariusbasically this is the context14:47:51
@raitobezarius:matrix.orgraitobezarius"I" am owner, I even have USAGE, CREATE on the schema14:48:00
@raitobezarius:matrix.orgraitobezariusand this still fails…14:48:03
@raitobezarius:matrix.orgraitobezariusI wonder if this is related to the usermap14:48:09
@raitobezarius:matrix.orgraitobezariusBut that'd be weird14:48:11
@raitobezarius:matrix.orgraitobezariusah I found the problem14:50:28
@raitobezarius:matrix.orgraitobezariusthe invidious test is weird14:50:31
@raitobezarius:matrix.orgraitobezariusand doing a lot of things14:50:32
@raitobezarius:matrix.orgraitobezariusok fixed.14:51:31
@raitobezarius:matrix.orgraitobezariusnow release notes, improved error messages and we ship this14:53:20
@raitobezarius:matrix.orgraitobezariusand we will deal with all the regressions later on in beta phase14:53:32
@raitobezarius:matrix.orgraitobezarius hexa: is there any plan on the Python 2.7 breakage stuff? 16:15:13
@raitobezarius:matrix.orgraitobezariusmost specifically, everything that depends on resholve16:15:19
@hexa:lossy.networkhexaa hack by k900 to disable the hook entirely on the python2 builder16:15:47

Show newer messages


Back to Room ListRoom Version: 6