| 17 Nov 2023 |
Vladimír Čunát | (I see like only 5 changes merged to staging in that period anyway.) | 06:17:47 |
Vladimír Čunát | (I guess we should create staging-23.11 soon.) | 06:18:11 |
Vladimír Čunát | * (I guess we should create staging-23.11 soon, as a target for PRs.) | 06:18:27 |
raitobezarius | FWIW, https://github.com/NixOS/nixpkgs/pull/267640 | 13:52:34 |
raitobezarius | I don't like this | 13:52:37 |
raitobezarius | bendlas: My PR will soon go out | 14:34:04 |
raitobezarius | I'm almost done with backward compat fixes | 14:34:14 |
bendlas | the postgres one? | 14:34:29 |
raitobezarius | yep | 14:34:42 |
bendlas | cool, yeah, I think the doc update should also be good to go | 14:35:16 |
raitobezarius | perfect | 14:36:33 |
raitobezarius | oh ffs… https://github.com/iv-org/invidious/blob/c5b87e3b5e5cc7f7f5c8baa7732bd6d81d8f910a/src/invidious/database/migrations/0001_create_channels_table.cr#L7 | 14:44:41 |
raitobezarius | I am having doubts if using explicitly the schema for creating tables can mess up our strategies or not | 14:46:20 |
bendlas | you mean the public. prefix? | 14:47:07 |
raitobezarius | yep | 14:47:29 |
bendlas | what would be the problem there, if we're the owner? | 14:47:37 |
raitobezarius | # TODO(raitobezarius to maintainers of invidious): I strongly advise to clean up the kemal specific
# thing for 24.05 and use `ensureDBOwnership`.
# See https://github.com/NixOS/nixpkgs/issues/216989
systemd.services.postgresql.postStart = lib.mkAfter ''
$PSQL -tAc 'ALTER DATABASE "${cfg.settings.db.dbname}" OWNER TO "${cfg.settings.db.user}";'
$PSQL -tAc 'GRANT USAGE, CREATE ON SCHEMA public TO "${cfg.settings.db.user}";'
'';
services.postgresql = {
enable = true;
ensureUsers = lib.singleton { name = cfg.settings.db.user; };
ensureDatabases = lib.singleton cfg.settings.db.dbname;
# This is only needed because the unix user invidious isn't the same as
# the database user. This tells postgres to map one to the other.
identMap = ''
invidious invidious ${cfg.settings.db.user}
'';
# And this specifically enables peer authentication for only this
# database, which allows passwordless authentication over the postgres
# unix socket for the user map given above.
authentication = ''
local ${cfg.settings.db.dbname} ${cfg.settings.db.user} peer map=invidious
'';
};
| 14:47:48 |
raitobezarius | basically this is the context | 14:47:51 |
raitobezarius | "I" am owner, I even have USAGE, CREATE on the schema | 14:48:00 |
raitobezarius | and this still fails… | 14:48:03 |
raitobezarius | I wonder if this is related to the usermap | 14:48:09 |
raitobezarius | But that'd be weird | 14:48:11 |
raitobezarius | ah I found the problem | 14:50:28 |
raitobezarius | the invidious test is weird | 14:50:31 |
raitobezarius | and doing a lot of things | 14:50:32 |
raitobezarius | ok fixed. | 14:51:31 |
raitobezarius | now release notes, improved error messages and we ship this | 14:53:20 |
raitobezarius | and we will deal with all the regressions later on in beta phase | 14:53:32 |
raitobezarius | hexa: is there any plan on the Python 2.7 breakage stuff? | 16:15:13 |
raitobezarius | most specifically, everything that depends on resholve | 16:15:19 |