| 13 Nov 2023 |
bendlas | true | 13:58:11 |
bendlas | ... except .. ensure* always puts permissions after db creation, but oh well ... | 14:00:00 |
raitobezarius | you can always do the permission creation on the preStart of the module you are interested | 14:03:45 |
raitobezarius | or you can have a postgresql-$myservice-install-permissions.service oneshot thingie | 14:03:56 |
raitobezarius | I posted https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/39?u=raitobezarius | 14:05:10 |
bendlas | In reply to @raitobezarius:matrix.org or you can have a postgresql-$myservice-install-permissions.service oneshot thingie good point. I'm wondering if we should advise people to do that instead of mkOrder sorcery | 14:06:26 |
raitobezarius | Yep, I think that might be the best option | 14:06:43 |
raitobezarius | We already have people doing local ensure logic in their own modules depending on the circumstances | 14:07:10 |
raitobezarius | We just move more complexity to NixOS modules authors | 14:07:18 |
bendlas | only fly in the ointment: With pre-15 psql, where db user isn't the owner, I think this wouldn't work, creating yet another lockstep - constraint on psql version :/ | 14:10:05 |
raitobezarius | we only need to provide the information | 14:10:55 |
raitobezarius | nixpkgs nixos modules are fine | 14:10:57 |
raitobezarius | non-nixpkgs nixos modules will probably have issues | 14:11:05 |
raitobezarius | we have to write documentation with this in mind | 14:11:09 |
raitobezarius | as long as we cover a significant amount of issues, I think we did what we could | 14:11:25 |
raitobezarius | I also unfortunately don't have much time myself as I have too much on my plate in general | 14:11:43 |
raitobezarius | So my priority is:
(1) ensuring nixpkgs is in a good state
(2) not mindlessly breaking out of tree users
(3) cleaning up this mess post branch off | 14:12:14 |
raitobezarius | How much we make (2) awesome is function of anyone's contributions here and in the PostgreSQL NixOS community | 14:12:33 |
bendlas | yeah, maybe best course is to just be as explicit as possible in docu, about the various problems with any of the approaches .. I'll have a look at postgres.md | 14:16:17 |
raitobezarius | I double checked and currently master didn't introduce new usage of ensurePermissions | 14:17:26 |
raitobezarius | So I will write release notes | 14:17:29 |
raitobezarius | And I will run testing in parallel | 14:17:45 |
raitobezarius | I wish nixpkgs-review could do that | 14:20:34 |
raitobezarius | well, it breaks on mastodon anyway | 14:25:15 |
raitobezarius | ok
matrix-sliding-sync
mautrix-facebook
zabbix-(proxy|server)
onlyoffice
tt-rs
hydron
| 14:33:49 |
raitobezarius | this stuff doesn't possess any test in nixpkgs | 14:33:55 |
raitobezarius | otherwise everything else should be covered by tests (which uncovered already issues in the PR) | 14:34:12 |
raitobezarius | I want to cry, people made stupid defaults | 14:43:21 |
raitobezarius | Mobilizon has a default database of mobilizon_prod, I switch it back to user as a default, this will make all existing deployments explode | 14:43:40 |
raitobezarius | * Mobilizon has a default database of mobilizon_prod, if I switch it back to user as a default, this will make all existing deployments explode | 14:45:09 |