| 11 Nov 2023 |
 Vladimír Čunát | * So that iteration is delayed but will at least contain more (recent) things. | 16:17:36 |
 raitobezarius | figsoda: we need to discuss delaying the branch off of some days | 17:41:45 |
| 12 Nov 2023 |
|  @lehmanator:gnulinux.club joined the room. | 12:03:38 |
| 13 Nov 2023 |
| raitobezarius | ahem | 13:29:37 |
| raitobezarius | so mastodon is still not upgraded from what I see | 13:29:42 |
 hexa | no response from kerstin on matrix | 13:30:16 |
| hexa | try mastodon: drop next | 13:30:47 |
| raitobezarius | I will do it myself | 13:30:49 |
| raitobezarius | I guess :D | 13:31:31 |
| raitobezarius | in the time being, I would appreciate if you could add to postgresql tests to test our big NixOS modules heavily relying on ensureXYZ with postgresql | 13:32:18 |
| raitobezarius | so any change to postgresql would catch them | 13:32:23 |
| raitobezarius | upgraded | 13:39:44 |
| raitobezarius | but now I am running into the PostgreSQL debacle | 13:39:53 |
| raitobezarius | OK, my decision is the following:
- we deprecate
ensurePermissions and leave the code alone, with a very big warning annoying message saying this option will be deleted in 24.05 if nothing is done to maintain it in a serious countenance, this buy 6 months to anyone who want to keep using this broken option, in the meantime, if anyone comes to complain about it to PGSQL maintainers who wanted to delete it will gently be told to send a fix rather than to complain. ensureDBOwnership should probably be mutually exclusive with ensurePermissions on the relevant pieces.
- we migrate everything inside nixpkgs to not use
ensurePermissions and we write migration guide from ensurePermissions using initialScript but also postStart as replacements with common snippets for the classical GRANT stuff.
| 13:43:59 |
| raitobezarius | We need to write:
- documentation for migration
- send an announcement for unstable users
- release notes for 23.11
ASAP
| 13:44:28 |
| raitobezarius | I will do the modifications to Ma27's PR to go with this | 13:44:42 |
 bendlas | good call! | 13:47:10 |
| bendlas |
- let's please steer users away from
initialScript. Maybe even deprecate as well (remember, this is only run once for the whole cluster, so huge pitfall when adding new DBs)
| 13:49:18 |
| bendlas | maybe do something like repeatableInit instead | 13:49:53 |
| raitobezarius | In reply to @bendlas:matrix.org
- let's please steer users away from
initialScript. Maybe even deprecate as well (remember, this is only run once for the whole cluster, so huge pitfall when adding new DBs)
Please do send a PR to postgresql.md to explain how to do this | 13:51:31 |
| raitobezarius | I will cherry-pick your commit with Ma27 PR or we will figure out something | 13:51:41 |
| raitobezarius | I don't think we should deprecate initialScript right now | 13:51:55 |
| raitobezarius | All deprecations are expensive and we are running out of consideration budgets :P | 13:52:05 |
| raitobezarius | But let's write how to migrate from ensurePermissions to postStart in a palatable way | 13:52:17 |
| bendlas | Yep, I can write something up. postStart is also not ideal, since it only lets you talk about ordering using mkAfter and the like, but should be enough for most people for now. | 13:55:31 |
| bendlas | maybe we can get a few people together to rethink all of ensure* across postgresql and mysql (and others?) | 13:56:22 |
| bendlas | ... for 24.05 that is | 13:56:28 |
| raitobezarius | Yep I am moving all the thinking to 24.05 | 13:57:29 |
| raitobezarius | In reply to @bendlas:matrix.org
Yep, I can write something up. postStart is also not ideal, since it only lets you talk about ordering using mkAfter and the like, but should be enough for most people for now. I think so too | 13:57:39 |
| raitobezarius | Like it's not less expressive than ensurePermissions | 13:57:46 |
