| 10 Nov 2023 |
 raitobezarius | tests = {
postgresql = nixosTests.postgresql-wal-receiver.${thisAttr};
pkg-config = testers.testMetaPkgConfig finalAttrs.finalPackage;
} // lib.optionalAttrs jitSupport {
postgresql-jit = nixosTests.postgresql-jit.${thisAttr};
};
} // lib.optionalAttrs jitSupport {
inherit (llvmPackages) llvm;
| 20:21:33 |
| raitobezarius | this is not enough | 20:21:35 |
 hexa | mix in some postgres consumers from the tested set | 20:22:14 |
| raitobezarius | yep | 20:22:17 |
| raitobezarius | But this is remediation for the future | 20:22:22 |
| raitobezarius | Right now, I would like to focus on short term remediations | 20:22:29 |
| hexa | agreed. | 20:22:32 |
| raitobezarius | Yep but this is our strength | 20:22:49 |
| raitobezarius | If we ship a proper thing, we can always backport more features later on | 20:22:58 |
 bendlas | It is a strength, being able to avoid collisions without holding up the world is a lot stronger though. | 20:25:36 |
 @gary.garyguo.net:lpc.events | In reply to @gary.garyguo.net:lpc.events
How about remove the default if stateVersion is 23.11, but keep it for older ones? raitobezarius any thoughts on this approach? will only break existing unstable users, but it'll be a very loud breakage instead of a silent one. | 20:26:37 |
| raitobezarius | In reply to @gary.garyguo.net:lpc.events
raitobezarius any thoughts on this approach? will only break existing unstable users, but it'll be a very loud breakage instead of a silent one. how does that change the problem of downgrading postgres? | 20:26:56 |
| raitobezarius | and how will it be a loud breakage? | 20:27:19 |
| raitobezarius | basically people will have "set postgresql version" | 20:27:30 |
| raitobezarius | and then they will set a pgsql version | 20:27:35 |
| @gary.garyguo.net:lpc.events | And they'll set pgsql version to the one that they're running? | 20:28:11 |
| raitobezarius | yep but how does that fix PG15 breakage? | 20:28:33 |
| raitobezarius | they will set PG15 and it will be broken with nixos modules | 20:28:43 |
| raitobezarius | and if they set PG14 and they were on PG15 it will make them believe their data disappeared? | 20:28:54 |
| @gary.garyguo.net:lpc.events | If they're already running PG15, then either they migrated from PG14, in which case nothing will break, or they started clean in which case PG15 is broken to begin with so they won't have any data. | 20:30:02 |
| bendlas |
If they're already running PG15, then either they migrated from PG14, in which case nothing will break
Wouldn't that mean that the data dir got upgraded and pg14 will refuse to start?
| 20:31:08 |
| bendlas |
so people who are on 15 now and want back to 14 would need to dump and restore
| 20:31:57 |
| @gary.garyguo.net:lpc.events | If you upgrade from PG14 to PG15, then you can keep using PG15 because PG15 changes the default permission on schema, but if a role is created before upgrade then it still keeps it. | 20:32:02 |
| @gary.garyguo.net:lpc.events | * If you upgrade from PG14 to PG15, then you can keep using PG15 because PG15 changes the default permission on schema, but if a role is created before upgrade then it still keeps the permission. | 20:32:26 |
| bendlas | still would require manual intervention, to set the default back up to 15 ... | 20:33:37 |
| bendlas | but yeah, maybe it makes sense to separate these failure modes out ... | 20:34:05 |
| bendlas | also, IMO it's called unstable for a reason, even if I don't like the sound of that sentiment ... | 20:34:31 |
| @gary.garyguo.net:lpc.events | * If you upgrade from PG14 to PG15, then you can keep using PG15 because PG15 changes the default permission on schema, but if a database is created before upgrade then it still keeps the old default permission. | 20:36:03 |
| bendlas | we have to also consider the social fallout: If you have to piss somebody of, and your only choice is "who?", then it's better to choose the group who's more likely to try to avoid a repetition of the experience by helping out in the future, instead of avoiding a repetition by stepping away ... | 20:38:34 |
| bendlas | but maybe there is a way to piss nobody off, let's give ourselves time until monday for a final decision, as raitobezarius said ... | 20:39:52 |
