| 10 Nov 2023 |
 bendlas | In reply to @raitobezarius:matrix.org
We would break anyone PGSQL 15 deployment That would be unfortunate for sure. But the way the problem seems to present itself, it's a judgement call between breaking unstable users (with the option of re-upgrading the default or downgrading the folder) or breaking stable out-of-tree users (with no option of downgrading). | 20:10:20 |
 raitobezarius | Well stable out of tree users have a downgrading option | 20:11:05 |
| raitobezarius | They stay on 23.05 and figure out what they want to do | 20:11:10 |
| raitobezarius | Plus they have a proper warning | 20:11:17 |
| raitobezarius | Whereas unstable users doesn't have any option to downgrade because it will silently break the postgresql.service | 20:11:41 |
| bendlas | downgrading within the release, but point taken | 20:11:51 |
| bendlas | What actually is the behavior of postgres when started on a folder that's "too new"? Maybe this condition could be checked for, if not at build time, .... | 20:14:09 |
 hexa | so, what I read is that downgrades are not supported by postgresql | 20:14:23 |
|  @gary.garyguo.net:lpc.events joined the room. | 20:14:27 |
| hexa | so people who are on 15 now and want back to 14 would need to dump and restore | 20:14:36 |
| @gary.garyguo.net:lpc.events | Apologize for upgrading postgres version... I migrated from 14 to 15 and everything worked fine, didn't know that it'll break new installations | 20:16:00 |
| @gary.garyguo.net:lpc.events | In reply to @raitobezarius:matrix.org
This is orthogonal to the situation How about remove the default if stateVersion is 23.11, but keep it for older ones? | 20:18:42 |
| hexa | My problem with that PR is that it didn't account for the changelog of postgresl 15. This goes well 500 times and then 1 time it will bite you. | 20:19:28 |
| raitobezarius | In reply to @gary.garyguo.net:lpc.events
Apologize for upgrading postgres version... I migrated from 14 to 15 and everything worked fine, didn't know that it'll break new installations Well, it happens but I think now we will make sure that postgres upgrades are blocked on a code owner who is a maintainer like systemd kinda | 20:19:59 |
| hexa | review requests for modules and tests 😕 | 20:20:39 |
| raitobezarius | And we should definitely enforce some passthru tests for postgresql | 20:20:52 |
| raitobezarius | that are related to our ensure options | 20:20:57 |
| raitobezarius | In reply to @hexa:lossy.network
review requests for modules and tests 😕 Not sure it would have produced anything tbh | 20:21:10 |
| raitobezarius | tests = {
postgresql = nixosTests.postgresql-wal-receiver.${thisAttr};
pkg-config = testers.testMetaPkgConfig finalAttrs.finalPackage;
} // lib.optionalAttrs jitSupport {
postgresql-jit = nixosTests.postgresql-jit.${thisAttr};
};
} // lib.optionalAttrs jitSupport {
inherit (llvmPackages) llvm;
| 20:21:33 |
| raitobezarius | this is not enough | 20:21:35 |
| hexa | mix in some postgres consumers from the tested set | 20:22:14 |
| raitobezarius | yep | 20:22:17 |
| raitobezarius | But this is remediation for the future | 20:22:22 |
| raitobezarius | Right now, I would like to focus on short term remediations | 20:22:29 |
| hexa | agreed. | 20:22:32 |
| raitobezarius | Yep but this is our strength | 20:22:49 |
| raitobezarius | If we ship a proper thing, we can always backport more features later on | 20:22:58 |
| bendlas | It is a strength, being able to avoid collisions without holding up the world is a lot stronger though. | 20:25:36 |
| @gary.garyguo.net:lpc.events | In reply to @gary.garyguo.net:lpc.events
How about remove the default if stateVersion is 23.11, but keep it for older ones? raitobezarius any thoughts on this approach? will only break existing unstable users, but it'll be a very loud breakage instead of a silent one. | 20:26:37 |
| raitobezarius | In reply to @gary.garyguo.net:lpc.events
raitobezarius any thoughts on this approach? will only break existing unstable users, but it'll be a very loud breakage instead of a silent one. how does that change the problem of downgrading postgres? | 20:26:56 |
