| 10 Nov 2023 |
bendlas | downgrading within the release, but point taken | 20:11:51 |
bendlas | What actually is the behavior of postgres when started on a folder that's "too new"? Maybe this condition could be checked for, if not at build time, .... | 20:14:09 |
hexa | so, what I read is that downgrades are not supported by postgresql | 20:14:23 |
| @gary.garyguo.net:lpc.events joined the room. | 20:14:27 |
hexa | so people who are on 15 now and want back to 14 would need to dump and restore | 20:14:36 |
@gary.garyguo.net:lpc.events | Apologize for upgrading postgres version... I migrated from 14 to 15 and everything worked fine, didn't know that it'll break new installations | 20:16:00 |
@gary.garyguo.net:lpc.events | In reply to @raitobezarius:matrix.org This is orthogonal to the situation How about remove the default if stateVersion is 23.11, but keep it for older ones? | 20:18:42 |
hexa | My problem with that PR is that it didn't account for the changelog of postgresl 15. This goes well 500 times and then 1 time it will bite you. | 20:19:28 |
raitobezarius | In reply to @gary.garyguo.net:lpc.events Apologize for upgrading postgres version... I migrated from 14 to 15 and everything worked fine, didn't know that it'll break new installations Well, it happens but I think now we will make sure that postgres upgrades are blocked on a code owner who is a maintainer like systemd kinda | 20:19:59 |
hexa | review requests for modules and tests 😕 | 20:20:39 |
raitobezarius | And we should definitely enforce some passthru tests for postgresql | 20:20:52 |
raitobezarius | that are related to our ensure options | 20:20:57 |
raitobezarius | In reply to @hexa:lossy.network review requests for modules and tests 😕 Not sure it would have produced anything tbh | 20:21:10 |
raitobezarius | tests = {
postgresql = nixosTests.postgresql-wal-receiver.${thisAttr};
pkg-config = testers.testMetaPkgConfig finalAttrs.finalPackage;
} // lib.optionalAttrs jitSupport {
postgresql-jit = nixosTests.postgresql-jit.${thisAttr};
};
} // lib.optionalAttrs jitSupport {
inherit (llvmPackages) llvm;
| 20:21:33 |
raitobezarius | this is not enough | 20:21:35 |
hexa | mix in some postgres consumers from the tested set | 20:22:14 |