| 21 May 2023 |
 Vladimír Čunát | (I've been a paid-job DNSSEC implementer for many years now, so I can talk relatively easily.) | 18:03:15 |
| Vladimír Čunát | * (I've been a paid-job DNSSEC implementer for several years now, so I can talk relatively easily.) | 18:03:27 |
| Vladimír Čunát | https://matrix.to/#/!tCyGickeVqkHsYjWnh:nixos.org/$1SY9meGntgzMbYg_lei-pmcpVXXLcoyOS1CYUSo_T7M?via=nixos.org&via=matrix.org&via=nixos.dev | 18:05:52 |
 raitobezarius | unexpected surprise hexa | 19:09:47 |
| raitobezarius | https://github.com/NixOS/nixpkgs/issues/193370 we can get rid of protobuf 3.7 | 19:09:51 |
 hexa | yeah, ghidra, I know | 19:10:09 |
| raitobezarius | also protobuf3_8 is not a thing anymore right? | 19:10:19 |
| raitobezarius | so I feel like the last thing has been removed | 19:10:23 |
| raitobezarius | we can drop them | 19:10:25 |
| hexa | please do | 19:31:11 |
| raitobezarius | yes sir yes | 19:43:23 |
| raitobezarius | https://github.com/NixOS/nixpkgs/pull/233293 | 19:51:14 |
 @julienmalka:matrix.org | Maybe add an alias ? | 19:52:09 |
| raitobezarius | oh you're right, thx | 19:52:23 |
| hexa | we didn't add any for the other versions | 19:52:38 |
| hexa | * we didn't add any for the other versions that got dropped 🤷 | 19:52:43 |
| raitobezarius | doesn't cost too much to do it though | 19:52:51 |
| raitobezarius | will let CI work | 19:53:17 |
| raitobezarius | and then we can merge | 19:53:23 |
 @me:indeednotjames.com | question:
breaking changes are currently restricted, branch-off is around the corner, stable channels don't have breaking changes either.
an open plausible PR (1.4.4 -> 1.5.1) has a breaking change, which affects the nixos module's services.plausible.adminUser.
how should one proceed?
keep the old version in 23.05 or introduce an breaking change?
context: https://github.com/NixOS/nixpkgs/pull/229201#issuecomment-1556292205
| 21:09:19 |
| hexa | not merge it? 🤔 | 21:11:02 |
| hexa | breaking changes are restricted → open has breaking change = no merge | 21:11:23 |
| hexa | * breaking changes are restricted → open PR has breaking change = no merge | 21:11:34 |
| hexa | you'll likely need to give more context | 21:11:46 |
| hexa | (give vs me taking it from the PR) | 21:12:05 |
| @me:indeednotjames.com | sure, will provide more context. but did you read the linked comment? | 21:12:47 |
| hexa | I did. The new version has an issue, that breaks the test | 21:13:24 |
| hexa | I don't get the point you're trying to make | 21:13:50 |
| hexa | * I did. The new version has an issue (no declarative admin user config), that breaks the test | 21:14:07 |
| Vladimír Čunát | The PR doesn't even seem to be in mergable state yet, regardless of restrictions. | 21:14:30 |
