| 19 May 2023 |
raitobezarius | please give the money to nixpkgs | 22:45:52 |
hexa | https://github.com/NixOS/nixpkgs/pull/232906 | 22:46:36 |
raitobezarius | Reading the V8 patch stuff, I'm not sure this PR is ready to be applied | 22:48:02 |
raitobezarius | And figuring out how to apply a patch to one of the dependency of one of our Ruby package is definitely not trivial I guess | 22:48:13 |
raitobezarius | Will try: bitwarden, openvscode-server (has already a PR), code-server, github-runner and Kibana 7.x | 22:49:02 |
hexa | can you say something about extconf.rb issue on ruby3.0? | 22:49:34 |
raitobezarius | is this happening with a Ruby 3.0 with no OpenSSL support? | 22:50:18 |
raitobezarius | In that case, it's normal | 22:50:28 |
raitobezarius | Ruby 3.0 will pick up a non-OpenSSL3 ready gem version instead of OpenSSL3 ready one because of (stupid) versions constraints | 22:50:46 |
raitobezarius | If you can give me the attrpath or something hexa I can work out a solution | 22:50:56 |
raitobezarius | We only need to force Ruby to accept a higher version | 22:51:03 |
hexa | ruby_3_0Packages.openssl | 22:51:11 |
raitobezarius | Give me a ec | 22:51:16 |
raitobezarius | * Give me a sec | 22:51:17 |
raitobezarius | you see | 22:52:05 |
raitobezarius | '' + opString (ver.majMin == "3.0" && opensslSupport) ''
# Replace the Gem by a OpenSSL3-compatible one.
echo "Hotpatching the OpenSSL gem with a 3.x series for OpenSSL 3 support..."
cp -vr ${openssl3Gem}/ext/openssl $sourceRoot/ext/
cp -vr ${openssl3Gem}/lib/ $sourceRoot/ext/openssl/
cp -vr ${openssl3Gem}/{History.md,openssl.gemspec} $sourceRoot/ext/openssl/
'';
| 22:52:07 |
raitobezarius | remove opensslSupport from there | 22:52:11 |
raitobezarius | and retry | 22:52:12 |
raitobezarius | this should hotpatch in all the cases | 22:52:17 |
raitobezarius | providing you a fresh and secure openssl gem | 22:52:22 |
raitobezarius | discourse: 🔴
bitwarden: 🔴
github-runner: 🔴 (https://github.com/actions/runner-images/discussions/5429)
| 22:59:03 |
raitobezarius | what the hell: https://github.com/bitwarden/clients/commit/9a41d5dc6f15e3e0df824891b063a32074340e38 | 23:05:50 |
raitobezarius | there is no tag containing this change?? | 23:05:55 |
raitobezarius | and 3 weeks ago… | 23:06:00 |
raitobezarius | latest release is one week ago | 23:06:05 |
raitobezarius | https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/26 wrote this | 23:07:54 |
raitobezarius | hexa: I'm in favor of letting Node.js 16 and OpenSSL 1.1 to be part of the cache until their actual death for this release | 23:44:29 |
raitobezarius | What do you think? (open to everyone on this channel) | 23:44:35 |
hexa | Not sure how | 23:52:15 |
raitobezarius | We change the logic in Hydra or nixpkgs to add those as exceptions | 23:53:57 |