17 Sep 2025 |
msgilligan | I this PR? https://github.com/NixOS/nixpkgs/pull/350736/ | 20:32:40 |
msgilligan | * In this PR? https://github.com/NixOS/nixpkgs/pull/350736/ | 20:32:53 |
msgilligan | Redacted or Malformed Event | 20:33:43 |
emily | yeah | 20:35:18 |
msgilligan | (I need to get in the habit of running nix fmt before pushing...) | 20:41:28 |
msgilligan | * I had a minor fmt error which is now fixed. (I need to get in the habit of running nix fmt before pushing...) | 20:41:53 |
msgilligan | * OK, here we go:
https://github.com/NixOS/nixpkgs/pull/443517/commits/a27db0ff606bac12a4bbba07fc291a04eef3c7f0 | 20:42:25 |
Infinidoge 🏳️⚧️ | I wish things weren't all being corralled into by-name, things that make sets of packages like Java don't really make sense to be shoved into that format | 21:37:40 |
Infinidoge 🏳️⚧️ | Eh, besides the point | 21:37:47 |
msgilligan | OK, so the zulu25 PR is passing all tests and is ready-for-review. I a have a follow-on PR that makes zulu25 the default zulu . And we need to remove zulu23 and zulu24 but I think we need to remove OpenJDK 23 first: https://github.com/NixOS/nixpkgs/pull/403247/ | 21:37:49 |
Infinidoge 🏳️⚧️ | Sorry for not helping much, mix of busy and trying to recover from Events:tm:
If there is anything that really needs a review ping me, but don't expect much on the issues for a little while | 21:38:47 |
msgilligan | zulu25 has one approval now, but still needs someone to merge it. | 21:43:00 |
msgilligan | I've also updated the Java 25 Support Tracking Issue and added a comment on why we prioritize 5 JDK distros. | 22:10:11 |
msgilligan | I said "we" based upon my understanding of the communities priorities and I invite comments if that list or the rationale for it should be changed. | 22:26:36 |
msgilligan | * I said "we" based upon my understanding of the community's priorities and I invite comments if that list or the rationale for it should be changed. | 22:26:50 |
msgilligan | And here's a massive DRAFT PR generated by running ./generate-sources.py in temurin-bin
I guess it should be split into 5 PRs, one per JDK version that is updated?
| 23:05:13 |
msgilligan | If I add 25 to the version list in generate-sources.py it seems to come up empty-handed as Temurin has not released JDK 25 yet. | 23:06:17 |
msgilligan | * And here's a massive-rebuild-triggering DRAFT PR generated by running ./generate-sources.py in temurin-bin
I guess it should be split into 5 PRs, one per JDK version that is updated?
| 23:19:32 |
msgilligan | I added it to the 25.11 milestone: https://github.com/NixOS/nixpkgs/milestone/31 | 23:34:56 |
18 Sep 2025 |
Tomodachi94 (they/them) | ant-contrib begone! | 01:27:27 |
msgilligan | I made a PR for graalvm-ce 25. | 19:33:35 |
msgilligan | Unlike the other PRs I've been making this one updates, bumps the default, and removes the deprecated (24.0.2) -- I did it this way because the current graalvm-ce packaging would need (probably minor) modification to support multiple versions. | 19:35:15 |
msgilligan | I've run nixpkgs-review on aarch64-linux and aarch64-darwin and found to issues:
| 19:41:14 |
msgilligan | * I've run nixpkgs-review on aarch64-linux and aarch64-darwin and found two issues:
| 19:41:25 |
msgilligan | I made a PR for the 2nd issue (which also happens on the current graalvm-ce-musl 24) | 19:42:05 |
msgilligan | and I cherry-picked the musl fix into the graavm-ce 25 PR | 19:44:21 |
msgilligan | So to move forward we should definitely review/merge the graalvm-ce-musl PR. | 19:45:23 |
msgilligan | And we could either:
a) modify the graalvm-ce 25 PR so that it adds 25 without removing 24 or making 25 the default
or
b) Wait for a fix to Issue 444069 (the mvnd build failure with Java 25) | 19:47:57 |
msgilligan | Any suggestions? | 19:48:14 |
msgilligan | If the maintainers of mvnd don't submit a patch soon, I'll probably do it -- I think it's an easy patch. | 21:05:00 |