| 20 Nov 2023 |
 nbp | * works for me with NixOS, Firefox & Privacy badger. (api.github.com is orange when clicking the privacy badger icon) | 17:40:12 |
|  @brainrape:ggpeti.com changed their display name from brainrake to brainrake (Old). | 20:18:00 |
 henrik-ch | In reply to @infinisil:matrix.org
henrik-ch: Did you perhaps already complete a walk through the tutorial? Review posted, it's slightly funny as you have revised slightly since I started the review, but hopefully still something usable. I will check with you tomorrow to see if it's a good point to rereview. | 21:57:22 |
| henrik-ch | In reply to @infinisil:matrix.org
henrik-ch: Did you perhaps already complete a walk through the tutorial? * Review posted, it's slightly funny as you have revised some parts since I started the review, but hopefully still something usable. I will check with you tomorrow to see if it's a good point to rereview. | 21:58:04 |
 infinisil | henrik-ch: Awesome thanks! No worries, I only appended, I didn't change anything existing :) | 21:58:37 |
| henrik-ch | By the way, it took me about 40 minutes from start to finish 😆 but that probably says more about my nix skills, and I preferred writing off the examples rather than copy the code from nix.dev for increased learning. | 22:03:46 |
| infinisil | henrik-ch: Ah nice, I think that makes this a pretty good size then! Though I also added a bunch of content afterwards :P | 22:07:29 |
| infinisil | I will remove some sections though after Valentin's feedback | 22:07:59 |
| 21 Nov 2023 |
| infinisil | Updated https://github.com/NixOS/nix.dev/pull/802, looking pretty good now imo :) | 02:40:41 |
| infinisil | * Updated https://github.com/NixOS/nix.dev/pull/802 and marked as ready for review, looking pretty good now imo :) | 02:40:52 |
| @brainrape:ggpeti.com left the room. | 15:27:59 |
|  Eelco changed their display name from niksnut to Eelco. | 16:37:09 |
| infinisil | fricklerhandwerk: Unless the github deployments thing is necessary for netlify (I don't think it is?), please turn it off (which needs repo admin permissions afaik), it's spamming events for every PR update: https://github.com/NixOS/nix.dev/pull/802 | 18:26:02 |
 asymmetric | In reply to @infinisil:matrix.org
fricklerhandwerk: Unless the github deployments thing is necessary for netlify (I don't think it is?), please turn it off (which needs repo admin permissions afaik), it's spamming events for every PR update: https://github.com/NixOS/nix.dev/pull/802 i think it comes from here: https://github.com/NixOS/nix.dev/blob/master/.github/workflows/build-and-deploy.yml | 18:38:55 |
| asymmetric | the action has an enable-github-deployment option which defaults to true. we could make it dependent on whether the push is to master instead | 18:39:46 |
| asymmetric | * the netlify action has an enable-github-deployment option which defaults to true. we could make it dependent on whether the push is to master instead | 18:40:01 |
| infinisil | asymmetric: Ah I see, but what's the point of these github deployments anyways? The comment it posts in the PR always contains an up-to-date link to the netlify deployment | 18:41:22 |
| infinisil | * asymmetric: Ah I see, but what's the point of these github deployments anyways? The comment it posts in the PR always contains an up-to-date link to the netlify deployment: https://github.com/NixOS/nix.dev/pull/802#issuecomment-1817733137 | 18:41:35 |
| asymmetric | don't think there's any special utility tbh.. other than getting a view of all deployments, and a summary in the project's sidebar | 18:43:59 |
| infinisil | asymmetric: https://github.com/NixOS/nix.dev/pull/803 | 18:54:03 |
| asymmetric | Do you get a This branch has not been deployed spammy message too? | 18:54:55 |
| infinisil | asymmetric: Oh yeah, interesting | 18:55:22 |
| infinisil | So maybe it doesn't work at all if that's disabled.. | 18:55:38 |
| infinisil | I just want it to post the comment | 18:56:02 |
| infinisil | Oh maybe wait until the action is done | 18:56:17 |
| asymmetric | it did deploy to netlify, it's just that github doesn't know about it | 18:56:27 |
| infinisil | Yup there it is: https://github.com/NixOS/nix.dev/pull/803#issuecomment-1821480699 :D | 18:56:28 |
| asymmetric | we would probably have to disable github deployments altogether (needs an admin) to get rid of that message | 18:56:59 |
| infinisil | The message is still there though 🤔 | 18:57:02 |
| asymmetric | In reply to @asymmetric:matrix.dapp.org.uk
it did deploy to netlify, it's just that github doesn't know about it yeah it's because of this | 18:57:18 |
