Nix Documentation - Public Room Timeline - Matrix Static

	Nix Documentation	407 Members
	Discussion about documentation improvements around the Nix ecosystem	80 Servers

You have reached the beginning of time (for this room).

Sender	Message	Time
12 Feb 2025
dish [Fox/It/She]	In reply to @djacu:matrix.org dish [Fox/It/She]: Individual commits ✅️ This seems really great. On thing I'm seeing for `pghero` is that the current entry for `extraArgs` links to https://puma.io/puma/#configuration That's a topic for a different PR I would say, this PR is specifically focused on ensuring all links work properly. Fixing incorrect links would be in a folloe-up PR, and can also start to be automated using a tool like lychee	17:33:58
dish [Fox/It/She]	* <mx-reply><blockquote><a href="https://matrix.to/#/!avYyleMexqjFHoqrME:nixos.org/$4kIuQzgDHR_snHmpQk9z6X-U7cElWuylfAIBAz0jEiY?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@djacu:matrix.org">@djacu:matrix.org</a><br /><a href="https://matrix.to/#/@pyrox:pyrox.dev">dish [Fox/It/She]</a>:<br>Individual commits ✅️<br>This seems really great.<br>On thing I'm seeing for <code>pghero</code> is that the current entry for <code>extraArgs</code> links to https://puma.io/puma/#configuration</blockquote></mx-reply>That's a topic for a different PR I would say, this PR is specifically focused on ensuring all links work properly. Fixing incorrect links would be in a follow-up PR, and can also start to be checked automatically using a tool like lychee	17:34:21
djacu	It's the same link as what is currently in master. But I didn't see that this line was already in master. https://github.com/NixOS/nixpkgs/blob/44534bc021b85c8d78e465021e21f33b856e2540/nixos/modules/services/misc/pghero.nix#L36 Which would explain why the link shows up on search.nixos.org https://search.nixos.org/options?channel=24.11&show=services.pghero.extraArgs&from=0&size=50&sort=relevance&type=packages&query=pghero So now I'm curious how the parenthesis in this commit fixes the link because it already appears to work. https://github.com/NixOS/nixpkgs/commit/a493b88f69f7c8dc8a259a2da41ecc0f6019bc3e The link in the `extraArgs` description appears to work in FF and Chrome	17:42:48
dish [Fox/It/She]	In reply to @djacu:matrix.org It's the same link as what is currently in master. But I didn't see that this line was already in master. https://github.com/NixOS/nixpkgs/blob/44534bc021b85c8d78e465021e21f33b856e2540/nixos/modules/services/misc/pghero.nix#L36 Which would explain why the link shows up on search.nixos.org https://search.nixos.org/options?channel=24.11&show=services.pghero.extraArgs&from=0&size=50&sort=relevance&type=packages&query=pghero So now I'm curious how the parenthesis in this commit fixes the link because it already appears to work. https://github.com/NixOS/nixpkgs/commit/a493b88f69f7c8dc8a259a2da41ecc0f6019bc3e The link in the `extraArgs` description appears to work in FF and Chrome looking at that specific one, it works because it's listed in a footnote, so that actually doesn't need to be changed. Good spotting	19:00:12
dish [Fox/It/She]	* looking at that specific one, it works because it's listed in a footnote, so that actually doesn't need to be changed. Good spotting!	19:00:16
dish [Fox/It/She]	removed that commit from my tree	19:01:43
djacu	I believe the same is true for the nextcloud commit https://github.com/NixOS/nixpkgs/commit/bb63f02d23b7af059146d528fd42af2a4a79ffe1	19:06:33
djacu	The `[1]` is a footnote link back to `[server-side encryption with customer-provided keys][1]` and I don't think it needs the `<>` around the URL.	19:07:23

Show newer messages

Back to Room ListRoom Version: 6