| 10 Jun 2024 |
|  NixOS Moderation Bot unbanned  jonringer. | 00:17:07 |
|  clvxaz joined the room. | 17:31:57 |
| 11 Jun 2024 |
|  camzer joined the room. | 23:51:53 |
| 12 Jun 2024 |
|  Lorenz Leutgeb removed their display name Lorenz Leutgeb. | 00:31:17 |
| Lorenz Leutgeb set their display name to Lorenz Leutgeb. | 00:32:51 |
| 15 Jun 2024 |
 getpsyched | I was wondering what's the status of PR review material in nixpkgs. So far, I've seen some points put in nixos/README.md and pkgs/README.md for reviewing contributions. Are there any other "official" or community efforts on this? | 12:04:37 |
 fricklerhandwerk | In reply to @getpsyched:matrix.org
I was wondering what's the status of PR review material in nixpkgs. So far, I've seen some points put in nixos/README.md and pkgs/README.md for reviewing contributions. Are there any other "official" or community efforts on this? These are the only places, to my knowledge. | 14:29:07 |
| getpsyched | Hmm. It might be worthwhile making a single resource where all of these things are combined as a comprehensive guide. I'm willing to take this on sometime soon. Wondering what would be a good place to put it; Maybe a dedicated project or, better yet, a wiki page 🤔 | 14:31:59 |
| getpsyched | * Hmm. It might be worthwhile making a single resource where all of these things are combined as a comprehensive guide. I'm willing to take this on sometime soon. Wondering what would be a good place to put it; Maybe a dedicated project or, better yet, a wiki page 🤔 | 14:32:06 |
 proofconstruction | Depends on what you mean by PR review materials, really. Guidelines for what to look for when reviewing? In any case, information scoped to a particular project should live in that project’s repo. | 20:47:06 |
| 16 Jun 2024 |
| getpsyched |
In any case, information scoped to a particular project should live in that project’s repo.
Yeah I don't mean project-specific quirks.
Guidelines for what to look for when reviewing?
At the crux of it, yes. Most of the basic conventions are known by most people but a lot of the relatively "newer" things like not overusing pname, or any other quirks specific to helper functions et al.
| 06:27:13 |
| 17 Jun 2024 |
 infinisil | getpsyched: Check out https://github.com/NixOS/nixpkgs/pull/245243 | 15:36:00 |
| infinisil | I think it would be best to continue with the effort to clean up the contributor docs, there's still a lot of work to be done | 15:36:16 |
