| 23 Sep 2024 |
loudgolem | yes, scheduled github action (once/twice a month) makes sense, along with a maintainer script for running manually. | 20:55:11 |
loudgolem | In reply to @fricklerhandwerk:matrix.org What we could and should do is more thoroughly run linkchecks on all of our domains: nixos.org, nix.dev, ... nix.dev (incl nix manual), nixos-homepage, nix (+manual), nixpkgs (nixos, nixpkgs manuals), nixos-wiki-infra all seem to need the lychee checks. maybe need to think about more than simply adding sheduled gha to all these repos? | 21:00:23 |
loudgolem | In reply to @fricklerhandwerk:matrix.org What we could and should do is more thoroughly run linkchecks on all of our domains: nixos.org, nix.dev, ... * nix.dev (incl nix manual), nixos-homepage, nix (+manual), nixpkgs (nixos, nixpkgs manuals), nixos-wiki-infra all seem to need the lychee checks. maybe need to think about it more than simply adding sheduled gha to all these repos? | 21:00:41 |
fricklerhandwerk | In reply to @phanirithvij:matrix.org nix.dev (incl nix manual), nixos-homepage, nix (+manual), nixpkgs (nixos, nixpkgs manuals), nixos-wiki-infra all seem to need the lychee checks. maybe need to think about more than simply adding sheduled gha to all these repos? Sure. But adding checks is a fist step that's not wrong | 21:00:50 |
fricklerhandwerk | In reply to @phanirithvij:matrix.org nix.dev (incl nix manual), nixos-homepage, nix (+manual), nixpkgs (nixos, nixpkgs manuals), nixos-wiki-infra all seem to need the lychee checks. maybe need to think about more than simply adding sheduled gha to all these repos? * Sure. But adding checks as a first step is not wrong, it won't make things worse | 21:01:09 |
fricklerhandwerk | (nix.dev has link checking and it regularly messes up builds because someone stops tolerating us hitting them) | 21:01:29 |
loudgolem | I don't think lychee check should be a blocker anywhere, it should just be a like warnings/report. | 21:03:53 |
fricklerhandwerk | * Sure. But adding checks as a first step is not wrong, it will prevent things from falling apart and gives us time to think | 21:03:56 |
loudgolem | * I don't think lychee check should be a blocker anywhere, it should just be like warnings/report. | 21:04:11 |
fricklerhandwerk | * Sure. But adding checks as a first step is not wrong, it will prevent things from falling apart while we're thinking | 21:04:21 |
loudgolem | In reply to @fricklerhandwerk:matrix.org (nix.dev has link checking and it regularly messes up builds because someone stops tolerating us hitting them) ok, linkcheck from sphinx. my experience with lychee with github urls even with github_token provided will still result in flaky 403 errors, I wonder how linkcheck is working fine | 21:11:42 |
loudgolem | also the redirect are good to know I guess, they can also be fixed. | 21:12:10 |
loudgolem | In reply to @fricklerhandwerk:matrix.org Sure. But adding checks as a first step is not wrong, it will prevent things from falling apart while we're thinking do you mean checks like this sphinx/linkcheck? | 21:13:04 |
loudgolem | does it work outside of sphinx? | 21:13:27 |
fricklerhandwerk | In reply to @phanirithvij:matrix.org does it work outside of sphinx? No, nix.dev linkchecks are pure Sphinix | 21:14:58 |
fricklerhandwerk | In reply to @phanirithvij:matrix.org does it work outside of sphinx? * No, nix.dev linkchecks are pure Sphinx | 21:15:15 |
loudgolem | I think scheduled gha is the way to go for external links | 21:15:30 |