| 12 Feb 2025 |
 dish [Fox/It/She] | Can i get some reviews on submitting https://github.com/pyrox0/nixpkgs/tree/markdown-links-fix as a PR? | 16:41:53 |
| dish [Fox/It/She] | Basically this branch is working on fixing any broken links that don't auto-linkify in the manuals | 16:42:13 |
| dish [Fox/It/She] | so that they are linked properly | 16:42:17 |
 djacu | dish [Fox/It/She]:
Individual commits ✅️
This seems really great.
On thing I'm seeing for pghero is that the current entry for extraArgs links to https://puma.io/puma/#configuration | 17:19:26 |
| dish [Fox/It/She] | In reply to @djacu:matrix.org
dish [Fox/It/She]:
Individual commits ✅️
This seems really great.
On thing I'm seeing for pghero is that the current entry for extraArgs links to https://puma.io/puma/#configuration That's a topic for a different PR I would say, this PR is specifically focused on ensuring all links work properly. Fixing incorrect links would be in a folloe-up PR, and can also start to be automated using a tool like lychee | 17:33:58 |
| dish [Fox/It/She] | * <mx-reply><blockquote><a href="https://matrix.to/#/!avYyleMexqjFHoqrME:nixos.org/$4kIuQzgDHR_snHmpQk9z6X-U7cElWuylfAIBAz0jEiY?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@djacu:matrix.org">@djacu:matrix.org</a><br /><a href="https://matrix.to/#/@pyrox:pyrox.dev">dish [Fox/It/She]</a>:<br>Individual commits ✅️<br>This seems really great.<br>On thing I'm seeing for <code>pghero</code> is that the current entry for <code>extraArgs</code> links to https://puma.io/puma/#configuration</blockquote></mx-reply>That's a topic for a different PR I would say, this PR is specifically focused on ensuring all links work properly. Fixing incorrect links would be in a follow-up PR, and can also start to be checked automatically using a tool like lychee | 17:34:21 |
| djacu | It's the same link as what is currently in master. But I didn't see that this line was already in master.
https://github.com/NixOS/nixpkgs/blob/44534bc021b85c8d78e465021e21f33b856e2540/nixos/modules/services/misc/pghero.nix#L36
Which would explain why the link shows up on search.nixos.org
https://search.nixos.org/options?channel=24.11&show=services.pghero.extraArgs&from=0&size=50&sort=relevance&type=packages&query=pghero
So now I'm curious how the parenthesis in this commit fixes the link because it already appears to work.
https://github.com/NixOS/nixpkgs/commit/a493b88f69f7c8dc8a259a2da41ecc0f6019bc3e
The link in the extraArgs description appears to work in FF and Chrome
| 17:42:48 |
| dish [Fox/It/She] | In reply to@djacu:matrix.org
It's the same link as what is currently in master. But I didn't see that this line was already in master.
https://github.com/NixOS/nixpkgs/blob/44534bc021b85c8d78e465021e21f33b856e2540/nixos/modules/services/misc/pghero.nix#L36
Which would explain why the link shows up on search.nixos.org
https://search.nixos.org/options?channel=24.11&show=services.pghero.extraArgs&from=0&size=50&sort=relevance&type=packages&query=pghero
So now I'm curious how the parenthesis in this commit fixes the link because it already appears to work.
https://github.com/NixOS/nixpkgs/commit/a493b88f69f7c8dc8a259a2da41ecc0f6019bc3e
The link in the extraArgs description appears to work in FF and Chrome
looking at that specific one, it works because it's listed in a footnote, so that actually doesn't need to be changed. Good spotting | 19:00:12 |
| dish [Fox/It/She] | * looking at that specific one, it works because it's listed in a footnote, so that actually doesn't need to be changed. Good spotting! | 19:00:16 |
| dish [Fox/It/She] | removed that commit from my tree | 19:01:43 |
| djacu | I believe the same is true for the nextcloud commit
https://github.com/NixOS/nixpkgs/commit/bb63f02d23b7af059146d528fd42af2a4a79ffe1 | 19:06:33 |
| djacu | The [1] is a footnote link back to [server-side encryption with customer-provided keys][1] and I don't think it needs the <> around the URL. | 19:07:23 |
| djacu | Other than that, I looked the rest and it seems solid. thanks a bunch! | 19:08:05 |
| dish [Fox/It/She] | the angle brackets are needed, see this screenshot of the manual: | 19:09:21 |
| dish [Fox/It/She] | 
Download screenshot-2025-02-12_14-08-56.png | 19:09:21 |
| dish [Fox/It/She] | note how the link is not correctly made into a clickable one | 19:09:35 |
| dish [Fox/It/She] | the footnote link can get its brackets removed though, yeah | 19:09:48 |
| djacu | Sorry should have been more clear. Just meant the first one. Agree that the one you show in the screenshot is correct. | 19:10:48 |
| dish [Fox/It/She] | pushed an updated commit set | 19:10:57 |
| djacu | fricklerhandwerk: These fixes appear to be good. Recommendation on moving forward? | 19:12:02 |
 fricklerhandwerk | In reply to @djacu:matrix.org
fricklerhandwerk: These fixes appear to be good. Recommendation on moving forward? Sure, more fixed links is always good! dish [Fox/It/She] please make a PR! | 19:15:09 |
| fricklerhandwerk | Thanks a lot you both! | 19:15:20 |
| dish [Fox/It/She] | In reply to@fricklerhandwerk:matrix.org
Sure, more fixed links is always good! dish [Fox/It/She] please make a PR! Will do! I'll send the link here when it's made | 19:15:46 |
| dish [Fox/It/She] | may I also add you both as reviewers on the PR? | 19:16:24 |
| djacu | In reply to @pyrox:pyrox.dev
may I also add you both as reviewers on the PR? sure! | 19:16:55 |
| dish [Fox/It/She] | https://github.com/nixos/nixpkgs/pull/381524 | 19:20:46 |
| dish [Fox/It/She] | * https://github.com/nixos/nixpkgs/pull/381524 submitted! | 19:20:50 |
| dish [Fox/It/She] | thank you both for your help | 19:21:12 |
| dish [Fox/It/She] | * thank you both for your help! | 19:21:51 |
| 13 Feb 2025 |
|  connor (he/him) (UTC-7) changed their display name from connor (he/him) (UTC-7) to connor (he/him) (UTC-8). | 06:58:58 |
