| 12 Apr 2024 |
fricklerhandwerk | Nice! I think we should not just rip out the mdDoc definition but rather throw with an informative error message for another release.
infinisil, guardian of architectural sanity, please give your blessing.
| 20:12:40 |
@terru:raccoon.college | fair ennough (should it be an outright error or just a trace for now?). if nothing else comes up i'd open a PR with this built on then-current master sometime tomorrow | 21:09:05 |
@terru:raccoon.college | * fair enough (should it be an outright error or just a trace for now?). if nothing else comes up i'd open a PR with this built on then-current master sometime tomorrow | 21:09:17 |
| 13 Apr 2024 |
djacu | Hey all
I could use some help with understanding how NRD works and how to document library files properly.
For reference, I am working on this PR that adds network functions to the nixpkgs library. https://github.com/NixOS/nixpkgs/pull/299409
The manual is failing to build and when I try to build it locally I see this:
RuntimeError: failed to render manual manual.md
error:
failed to render manual manual.md
caused by:
rendering lib.md
caused by:
rendering functions.md
caused by:
rendering functions/library.md
caused by:
rendering /nix/store/b94j5fg7rf3m7w6s76by60jd7hb1avry-nixpkgs-lib-docs/network.md
caused by:
bad local reference, id #function-library-lib.network.ipv4.fromCidrString not known
which i've determine to be caused by this line in the default.nix doc comment
- [`lib.network.ipv4.fromCidrString`](#function-library-lib.network.ipv4.fromCidrString):
This makes sense that it can't find it because if I remove the line, it does build, but there is no documentation for the functions I have created in the manual.
Any advice?
| 04:10:04 |
djacu | okay more info I found out.
If i change the reference from
#function-library-lib.network.ipv4.fromCidrString
to
#function-library-lib.network.ipv4
it builds and renders fine
but ipv4 is just a namespace for all my functions inside of the network library. Can we not access functions inside of an attrset or do I need to write things differently so it works?
| 04:16:10 |
tomberek | Not sure if that much nesting is ok: https://github.com/NixOS/nixpkgs/blob/master/doc/doc-support/lib-function-locations.nix#L25-L31 | 04:16:49 |
tomberek | If I remove the "ipv4" layer of nesting and adjust the reference, it builds okay. So it seems like the doc infra doesn't allow that much? | 04:18:49 |
djacu | Well that is unfortunate. Thanks for verifying my results tomberek | 04:24:09 |
@olafklingt:matrix.org | is your use of doc comment inentional? Starting with "/**"?
https://github.com/nix-community/nixdoc | 10:48:13 |
@olafklingt:matrix.org | Sorry yes obviously it's intentional 😄 sorry for the noise | 10:50:16 |
@terru:raccoon.college | * hey all, i recently got it into my head to write a little tool which automatically edits nix files without messing them up, and got it to a point where it can remove e.g. all mentions of lib.mdDoc from nixpkgs. I have a changeset of it applied to master or ~an hour ago here: https://github.com/NixOS/nixpkgs/compare/5d401f9ed627a869fd231f63e4f8380022dcded5...stuebinm:nixpkgs:eed6c7c5de883d78d8185adaf4949c0fb7f8f44f
i have not opened a pull request with it because that'd just ping a lot of people and i'm not sure if it would be accepted or people here would even be interested, so I thought I'd ask here beforehand
| 13:13:37 |
infinisil | In reply to @terru:raccoon.college fair enough (should it be an outright error or just a trace for now?). if nothing else comes up i'd open a PR with this built on then-current master sometime tomorrow You can use lib.warn (which gives a trace) :) | 13:36:52 |
@terru:raccoon.college | i know. my question was more: should it give a trace, or should it give a hard (failing) error directly? | 13:38:22 |
@terru:raccoon.college | but i'll use lib.warn if that's preferred (just be a second, I was literally just writing the PR message for this 😄) | 13:39:15 |
infinisil | Answered on GitHub: https://github.com/NixOS/nixpkgs/pull/299409#issuecomment-2053650225 | 13:41:19 |
infinisil | (it can work) | 13:41:35 |
infinisil | terru: Yeah just a trace for now is my preference | 13:42:04 |
@terru:raccoon.college | fair | 13:45:27 |
@terru:raccoon.college | you should've gotten a ping from github with the PR ;) | 13:45:56 |
@terru:raccoon.college | * you should've just gotten a ping from github with the PR ;) | 13:46:00 |
@terru:raccoon.college | grr forgot the final force-push changing the throw to lib.warn, sorry to everyone who now got pinged twice 🙈 | 13:48:16 |
| @alex3829:matrix.org joined the room. | 16:04:39 |
| 14 Apr 2024 |
| @windchimesofmagic:matrix.org left the room. | 17:37:29 |
| 15 Apr 2024 |
| soenke joined the room. | 22:08:57 |
| 16 Apr 2024 |
| thoth joined the room. | 09:02:05 |
| 17 Apr 2024 |
| @alex3829:matrix.org changed their display name from alex3829 to real_z22. | 04:36:12 |
| @alex3829:matrix.org changed their display name from real_z22 to real_z2. | 05:33:42 |
| JoelMcCracken joined the room. | 16:26:38 |
| 18 Apr 2024 |
| @fractivore:cyberia.club left the room. | 02:27:17 |
| @nscnt:matrix.org joined the room. | 13:21:24 |