| 26 Jun 2024 |
infinisil | Johannes Kirschbauer @hsjobeki: Merged all except the module system one, nice work! 🚀 | 20:25:54 |
infinisil | I really want to push towards faster merging of PRs that look good. If problems arrive, they can be fixed with another PR :) | 20:27:02 |
proofconstruction | I broadly agree with this, but also want to point out that even after all the PRs we still only have today's Nix with all its problems 🙂 | 21:56:17 |
| 27 Jun 2024 |
| Nikke joined the room. | 16:05:49 |
| 28 Jun 2024 |
| @axiomss:matrix.org left the room. | 04:15:13 |
@johannes.kirschbauer:scs.ems.host | xD friday semver checks with infinisil list comprehension method ^^ (Please do not use this)
nix-repl> [ 1.0.0 ] > [ 0.9.9 prerelease:build ]
true
nix-repl> [ 1.0.0 ] > [ 1.0.0 prerelease:build ]
false
nix-repl> [ 1.0.0 release:build ] > [ 1.0.0 prerelease:build ]
true
https://jubianchi.github.io/semver-check/#/^1.0.0-release%2Bbuild/1.0.0-prerelrease%2Bbuild
| 15:45:00 |
@johannes.kirschbauer:scs.ems.host | * xD friday semver checks with infinisil list comprehension method ^^ (Please do not use this)
nix-repl> [ 1.0.0 ] > [ 0.9.9 prerelease:build ]
true
nix-repl> [ 1.0.0 ] > [ 1.0.0 prerelease:build ]
false
nix-repl> [ 1.0.0 release:build ] > [ 1.0.0 prerelease:build ]
true
https://jubianchi.github.io/semver-check/#/^1.0.0-release%2Bbuild/1.0.0-prerelrease%2Bbuild
Would be fun if that worked for semver in general
| 15:45:31 |
infinisil | Haha nice | 15:46:53 |
@johannes.kirschbauer:scs.ems.host | This should actually work because. Pre-release and build identifiers are compared lexicographically in ASCII sort order | 15:51:43 |
@johannes.kirschbauer:scs.ems.host | * This should actually work because. Pre-release identifiers are compared lexicographically in ASCII sort order | 15:52:13 |
@johannes.kirschbauer:scs.ems.host | (Build doesnt affect the order though) | 15:52:26 |
@johannes.kirschbauer:scs.ems.host | * (Build tags doesnt affect the order though) | 15:52:47 |
@johannes.kirschbauer:scs.ems.host | * xD friday semver checks with infinisil list comprehension method ^^ (Please do not use this)
nix-repl> [ 1.0.0 ] > [ 0.9.9 prerelease:build ]
true
nix-repl> [ 1.0.0 ] > [ 1.0.0 prerelease:build ]
false
nix-repl> [ 1.0.0 release:build ] > [ 1.0.0 prerelease:build ]
true
nix-repl> [ 3.1.4 rc:1.0+20230401.build1234 ] < [ 3.1.4 rc:1.1+20230401.build1234 ]
true
nix-repl> [ 3.1.4 rc:1.0+20230401.build1234 ] > [ 3.1.4 rc:1.1+20230401.build1234 ]
false
https://jubianchi.github.io/semver-check/#/^1.0.0-release%2Bbuild/1.0.0-prerelrease%2Bbuild
Would be fun if that worked for semver in general
| 16:01:00 |
@johannes.kirschbauer:scs.ems.host | * (Build tags doesnt affect the order though, thats why i wont work for all cases) | 16:02:32 |
@johannes.kirschbauer:scs.ems.host | * (Build tags doesnt affect the order though, thats why it wont work for all cases) | 16:02:44 |
purepani | In reply to @johannes.kirschbauer:scs.ems.host
xD friday semver checks with infinisil list comprehension method ^^ (Please do not use this)
nix-repl> [ 1.0.0 ] > [ 0.9.9 prerelease:build ]
true
nix-repl> [ 1.0.0 ] > [ 1.0.0 prerelease:build ]
false
nix-repl> [ 1.0.0 release:build ] > [ 1.0.0 prerelease:build ]
true
nix-repl> [ 3.1.4 rc:1.0+20230401.build1234 ] < [ 3.1.4 rc:1.1+20230401.build1234 ]
true
nix-repl> [ 3.1.4 rc:1.0+20230401.build1234 ] > [ 3.1.4 rc:1.1+20230401.build1234 ]
false
https://jubianchi.github.io/semver-check/#/^1.0.0-release%2Bbuild/1.0.0-prerelrease%2Bbuild
Would be fun if that worked for semver in general
what on earth ahaha | 17:39:34 |
| 29 Jun 2024 |
| mib 🥐 joined the room. | 22:24:29 |
| 2 Jul 2024 |
| Zyansheep joined the room. | 04:36:20 |
| @fastloris:tchncs.de joined the room. | 11:06:45 |
fricklerhandwerk | In reply to @fricklerhandwerk:matrix.org Thanks Stefan Schroeder Johannes Kirschbauer @hsjobeki, I'll take that into account when I get to recording the next thing Here's another video: https://youtu.be/82UxXZv6Vhk
I haven't recorded a new one yet, but I'll incorporate any feedback for the next thing I do
| 13:41:13 |
| @janik0:matrix.org left the room. | 13:44:11 |
@johannes.kirschbauer:scs.ems.host | fricklerhandwerk: great video.
🚀
I find it always impressing how you find and fix these little odd things. | 15:31:01 |
@johannes.kirschbauer:scs.ems.host | Who got commit rights and would like to review a 2k lines changed pr? 😬
https://github.com/NixOS/nixpkgs/pull/323843/files | 15:36:41 |
@johannes.kirschbauer:scs.ems.host | Should i split it? | 15:38:11 |
@johannes.kirschbauer:scs.ems.host | * Who got commit rights and/or would like to review a 2k lines changed pr? 😬
https://github.com/NixOS/nixpkgs/pull/323843/files | 16:05:39 |
djacu | I don't have commit rights but taking a look.
I'm seeing some things that I can't find in RFC 145. Was the format updated in a another RFC? | 16:12:00 |
fricklerhandwerk | I can take a look this week, and merge some little fixups on the way | 16:15:49 |
fricklerhandwerk | Overall it's not that bad, looks pretty mechanical | 16:16:02 |
fricklerhandwerk | * Overall it's not that bad in terms of size, looks pretty mechanical. | 16:16:12 |
@johannes.kirschbauer:scs.ems.host | djacu: no the RFC is not strict in those terms. danielsidhion and me worked on what is more like conventions. There are other files in lib that use commonmark already in comments for reference | 16:29:54 |