| 13 May 2024 |
Philip Taron (UTC-8) | I see that pkgs/top-level/release.nix is the entry point for doc/default.nix. Other than the default variable there, I don't see where nixpkgs is actually filled out. | 15:55:48 |
infinisil | Philip Taron (UTC-8): That nixpkgs is set by Hydra :) | 16:51:18 |
infinisil | I think I've seen some recent discussions about exposing doc/default.nix from pkgs, but I don't think there was a reason against not doing that | 16:52:08 |
infinisil | Seems fine to me! | 16:52:12 |
infinisil | fricklerhandwerk: (unrelated to the above): We created @NixOS/documentation-reviewers as (docs team - Valentin) to limit your notifications, but I guess we don't need this anymore, right? If so I can remove it | 16:55:57 |
infinisil | Now opened https://github.com/NixOS/nix.dev/pull/978 to remove the mention of documentation-reviewers | 17:07:37 |
fricklerhandwerk | In reply to @philiptaron:matrix.org I see that pkgs/top-level/release.nix is the entry point for doc/default.nix. Other than the default variable there, I don't see where nixpkgs is actually filled out. This is a thoroughly cursed code path, I also ran into it recently. I think there is also some passing happening in flake.nix | 17:30:42 |
fricklerhandwerk | In reply to @infinisil:matrix.org Now opened https://github.com/NixOS/nix.dev/pull/978 to remove the mention of documentation-reviewers There’s also something in the Nixpkgs contributing guide though? | 17:31:32 |
Philip Taron (UTC-8) | In reply to @fricklerhandwerk:matrix.org This is a thoroughly cursed code path, I also ran into it recently. I think there is also some passing happening in flake.nix Thanks for the pointer. I do see that nixpkgs = self now. Good to know... | 17:35:09 |
infinisil | In reply to @fricklerhandwerk:matrix.org There’s also something in the Nixpkgs contributing guide though? Adding to https://github.com/NixOS/nixpkgs/pull/311414 | 17:56:31 |
infinisil | Philip Taron (UTC-8): https://github.com/NixOS/hydra/blob/998df1657e7e9bd3c2d54f8106eae5a325e17e02/src/script/hydra-eval-jobset#L294-L309 | 18:35:34 |
infinisil | documentation-reviewers team is now gone :) | 19:26:04 |
Philip Taron (UTC-8) | In reply to @infinisil:matrix.org Seems fine to me! https://github.com/NixOS/nixpkgs/pull/311459 -- it was a little easier than I expected. | 20:23:38 |
Philip Taron (UTC-8) | It's marked Draft because I fell afoul of the "Don | 20:25:32 |
Philip Taron (UTC-8) | * It's marked Draft because I fell afoul of the "Don't reach outside of your directory" rule in the by-name checker: https://github.com/NixOS/nixpkgs/actions/runs/9069302338/job/24918546803?pr=311459 | 20:25:53 |
Philip Taron (UTC-8) | * It's marked Draft because I fell afoul of the "Don't reach outside of your directory" rule in the by-name checker: https://github.com/NixOS/nixpkgs/actions/runs/9069363512/job/24918746093?pr=311459 | 20:32:26 |
infinisil | Ahh right 😅 | 23:13:54 |
| 14 May 2024 |
| infinisil changed their profile picture. | 17:44:44 |
fricklerhandwerk | I'm hanging out in https://jitsi.lassul.us/nix-documentation for office hours | 18:58:47 |
fricklerhandwerk | Feel free to join and chat or hack on docs! | 19:03:04 |
@stablejoy:matrix.org | Id love to! Im on trip atm but these hours are also good for future office hours! | 19:17:56 |
| 15 May 2024 |
phaer | I remember seeing a pad with a table comparing different markdown implementations in the context of how useful they would be for nix(os) documentation. But I can't find it anymore. Does anyone have a link and/or the answer on which implementation has been chosen in the end? | 07:21:03 |
phaer | Seems to be markdown-it-py, according to https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/tools/nix/nixos-render-docs/default.nix#L63 :) | 07:37:52 |
fricklerhandwerk | In reply to @phaer:matrix.org I remember seeing a pad with a table comparing different markdown implementations in the context of how useful they would be for nix(os) documentation. But I can't find it anymore. Does anyone have a link and/or the answer on which implementation has been chosen in the end? danielsidhion made an overview here: https://ethercalc.net/dc4vcnnl8zv0
Also linked from here: https://discourse.nixos.org/t/a-roadmap-for-the-documentation-ecosystem/42328
| 08:09:37 |
fricklerhandwerk | BTW it's documentation office hours again: https://jitsi.lassul.us/nix-documentation | 08:16:00 |
| raghavsood joined the room. | 08:28:19 |
| raghavsood set a profile picture. | 08:38:25 |
Soenke Klinger | Should I use the stable or the unstable manual when I place a link from the the Wiki to the manual? | 14:33:03 |
Soenke Klinger | * Should I use the stable or the unstable manual when I place a link from the the Wiki to the NixOS manual? | 14:33:59 |
infinisil | Soenke Klinger: Preferably the stable one | 14:39:11 |