| 12 Jan 2024 |
 danielsidhion | Just went through a rabbithole when creating a PR, and have a few questions that I think would be better asked here rather than spending even more time trying to dig things:
- Does anyone know why a bunch of places in our docs use the
shellSession/ShellSession info on code blocks? https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20shellsession&type=code
From my investigation, it seems to be ignored by the highlighting library we use in the manuals
- A look into the highlighting library used in the manuals makes me believe that the unstable manuals haven't been updated in nixos.org for at least 2 months (library was updated from v9 to v11 ~2mo ago, but the version used in nixos.org is still v9). I can't spend more time today looking into this, but I think this isn't normal. Did something break in the manual -> nixos.org pipeline?
| 14:45:38 |
 Chris McDonough | no problem's gonna be solved by me bitching in here, sorry, i should have kept it to myself. thanks for the intervention. i'll try to contribute meaningfully and regulate my aversion to various comms styles. | 15:45:20 |
 Lunaphied | I think your contribution was fine and valuable feedback to the team, I wouldn't like to lose out on those kinds of contributions personally | 16:01:12 |
 infinisil | In reply to @danielsidhion:nixos.dev
Just went through a rabbithole when creating a PR, and have a few questions that I think would be better asked here rather than spending even more time trying to dig things:
- Does anyone know why a bunch of places in our docs use the
shellSession/ShellSession info on code blocks? https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20shellsession&type=code
From my investigation, it seems to be ignored by the highlighting library we use in the manuals
- A look into the highlighting library used in the manuals makes me believe that the unstable manuals haven't been updated in nixos.org for at least 2 months (library was updated from v9 to v11 ~2mo ago, but the version used in nixos.org is still v9). I can't spend more time today looking into this, but I think this isn't normal. Did something break in the manual -> nixos.org pipeline?
No idea about the first, but the second one oh no.. | 16:15:33 |
| infinisil | Indeed there should be commits to https://github.com/NixOS/nixos-homepage/commits/master/ every day to update the website with the latest versions, but this apparently broke.. | 16:15:58 |
| infinisil | Lol: https://github.com/NixOS/nixos-homepage/actions/runs/7496066602/job/20407403287#step:5:12 | 16:16:18 |
| infinisil | Run bash ./scripts/update.sh
Updating flake inputs...
error: unrecognised flag '--update-input'
Try 'nix --help' for more information.
Error: Process completed with exit code 1.
| 16:16:29 |
| infinisil | Wait there's not even a deprecation message | 16:19:13 |
| infinisil | Wait what, the current latest version is 2.19.2, which does have a deprecation message (tried it locally):
warning: '--update-input' is a deprecated alias for 'flake update' and will be removed in a future version.
| 16:21:25 |
| infinisil | Investigating.. | 16:22:34 |
| Chris McDonough | danielsidhion: it's not on the list, but i'm starting to apply your function argument defintion list stuff to a PR I already have open... https://github.com/NixOS/nixpkgs/pull/277534/files | 16:27:35 |
| infinisil | Ohh, something really bad might be happening, the Nixpkgs master jobset doesn't exist anymore | 16:28:31 |
| infinisil | Never mind, it's just not listed in https://hydra.nixos.org/project/nixpkgs anymore, it does still exist: https://hydra.nixos.org/jobset/nixpkgs/trunk | 16:29:50 |
| danielsidhion | In reply to @mcdonc:matrix.org
danielsidhion: it's not on the list, but i'm starting to apply your function argument defintion list stuff to a PR I already have open... https://github.com/NixOS/nixpkgs/pull/277534/files This is amazing, thanks a lot! No need to update your PR again, but I just opened https://github.com/NixOS/nixpkgs/pull/280520 to add a few more conventions that I discussed in the latest meeting. | 16:31:33 |
| Chris McDonough | great... i'll try to put that file in shape | 16:35:10 |
| infinisil | In reply to @infinisil:matrix.org
Investigating.. Figured it out, 2.19.1 doesn't have the deprecation warning. Looks like that was only added in 2.19.2 | 16:35:37 |
| infinisil | And actually, the cachix-install-action was just updated to use 2.19.2 today, so maybe the homepage will update just by forcing a retry | 16:36:27 |
| infinisil | Trying it here: https://github.com/NixOS/nixos-homepage/actions/runs/7504900929/job/20432973247 | 16:37:21 |
| danielsidhion | Should we update https://github.com/NixOS/nixos-homepage/blob/master/scripts/update.sh to use nix flake update instead of nix flake lock then? | 16:37:51 |
| infinisil | danielsidhion: I might do that yeah | 16:39:00 |
| infinisil | (If 2.19.1 actually supports that already) | 16:39:33 |
| danielsidhion | I think it does, if the docs I'm reading are right | 16:40:20 |
| infinisil | Yeah | 16:42:32 |
| infinisil | But it doesn't support updating multiple inputs in a single command :/ | 16:43:53 |
| Chris McDonough | danielsidhion: if i could ask in context, it looks like https://github.com/NixOS/nixpkgs/pull/280520 adds an "Inputs" title... should there be a corresponding "Outputs"? | 16:45:16 |
| Chris McDonough | Or I guess "Output" heh | 16:46:36 |
| danielsidhion | Add an "output/outputs" if it makes sense. The example I put there might be somewhat bad and need rework, because I had in mind a function that outputs a derivation, so "passthru outputs" makes more sense | 16:48:58 |
| danielsidhion | For lib-style functions it might make more sense to use "output/outputs" | 16:49:34 |
| Chris McDonough | ok, i think that makes sense | 16:49:59 |
| Chris McDonough | in that trivial builders file, we have sort of haskell-style "runCommand :: String -> AttrSet -> String -> Derivation" style of documenting inputs and outputs... i'm going to remove those and go with that | 16:51:23 |
