| 27 Jan 2024 |
fricklerhandwerk | In reply to @jade_:matrix.org 9999years wrote some docs for it but they were in a pr that was rejected for containing guide level docs I actually started messing around with that and got stuck in a rabbit hole to refactor callPackage... | 02:09:23 |
infinisil | In reply to @jade_:matrix.org 9999years wrote some docs for it but they were in a pr that was rejected for containing guide level docs This is the PR: https://github.com/NixOS/nixpkgs/pull/270696 I think it's dishonest to call that rejected. I just said that part of that PR should go to nix.dev instead. I even mentioned that the content is looking good. | 03:45:53 |
infinisil | Btw I'm fairly lenient with documentation (at least recently). I don't really care about how stuff is written down exactly. I just check some basic stuff like if it's in the right place, if it's correct, etc. As long as that's the case, I'm willing to merge doc changes | 03:52:45 |
infinisil | This is in contrast to actual interface changes in the code, which are full of intricacies that we can't easily revert once committed. So I take much more care in reviewing such PRs :) | 03:54:31 |
Charles | https://github.com/NixOS/nixpkgs/pull/264621#issuecomment-1910806642 this kind of thing should probably go in the nixos manual shouldn't it? (i thought i'd ask here first since i don't want to comment on this PR just to be wrong lol) | 04:34:02 |
@jade_:matrix.org | I think that was a misread/miscommunication then, sorry about that. | 05:05:50 |
| @dooy:matrix.org changed their display name from Dooygoy to stablejoy. | 13:37:38 |
| @lehmanator:gnulinux.club removed their profile picture. | 16:53:50 |
| @lehmanator:gnulinux.club removed their display name Sam Lehman. | 17:02:02 |
| @lehmanator:gnulinux.club left the room. | 17:05:08 |