| 30 Jan 2022 |
 Jan Tojnar | * similarly the fetching section – people will want nixpkgs fetchers 90 % of the time | 00:14:35 |
 joepie91 🏳️🌈 | the nixpkgs fetchers! I knew I was forgetting something | 00:14:57 |
| joepie91 🏳️🌈 | swapped around the derivation functions and added a note to only use the builtin if nixpkgs is not available | 00:15:21 |
| joepie91 🏳️🌈 | will add the nixpkgs fetchers at some later time :p | 00:15:42 |
| joepie91 🏳️🌈 | I've left a FIXME in my sheet | 00:15:49 |
| Jan Tojnar | DocBook is spelt with capital B e.g. in literalDocBook | 00:16:19 |
| joepie91 🏳️🌈 | oops | 00:16:48 |
| joepie91 🏳️🌈 | fixed | 00:17:04 |
| Jan Tojnar | there is also pkgs.nix-gitignore if you want to avoid flakes https://nixos.org/manual/nixpkgs/stable/#sec-pkgs-nix-gitignore | 00:21:20 |
| joepie91 🏳️🌈 | ah, handy | 00:22:39 |
| joepie91 🏳️🌈 | will have a look at that later | 00:22:49 |
| Jan Tojnar | but the functions I had in mind and actually used are lib.sources.cleanSource & co. | 00:23:05 |
| Jan Tojnar | which are based on builtins.path | 00:23:13 |
| joepie91 🏳️🌈 | are those documented? | 00:23:21 |
| Jan Tojnar | not sure, I mostly just look to code for docs | 00:23:53 |
| joepie91 🏳️🌈 | right :p | 00:24:20 |
| Jan Tojnar | looks like it is incomplete for some reason | 00:25:51 |
| Jan Tojnar | https://nixos.org/manual/nixpkgs/stable/#sec-functions-library-sources | 00:25:52 |
| joepie91 🏳️🌈 | yeah that section looked weirdly empty to me | 00:26:46 |
| joepie91 🏳️🌈 | couldn't really derive any understanding from it | 00:26:59 |
| Jan Tojnar | looks like it might only extract C style-comments | 00:27:25 |
| Jan Tojnar | rather than the shell-style ones | 00:27:33 |
| joepie91 🏳️🌈 | there's at least one misparse too | 00:27:36 |
| Jan Tojnar | which are used for most docs in the sources.nix | 00:27:50 |
| joepie91 🏳️🌈 | under 5.1.4.4. lib.trivial.concat | 00:27:51 |
| joepie91 🏳️🌈 | alright, I've been at this for 8-9 hours and it's nearly bedtime so I gotta detach now :p feel free to leave any further review comments and/or questions and I'll read them in the morning | 00:29:38 |
| joepie91 🏳️🌈 | or what passes as 'morning' for me anyway | 00:29:52 |
| joepie91 🏳️🌈 | (thanks, btw!) | 00:44:18 |
| Jan Tojnar | any comments on https://github.com/NixOS/nixpkgs/pull/157336? | 19:09:44 |
 asymmetric | i'm just a bit confused about why you switched some multilines to #, e.g. in lib/trivial.nix, but then also converted some single-line comments to /* ... */ | 19:20:47 |
