| 16 Oct 2025 |
 matthewcroughan | /nix/store/bvp4jwn1ibkjh7yhr2mlcxxd908y4x4v-perl-5.40.0/lib/perl5/5.40.0/aarch64-linux-thread-multi/CORE/perl.h:3358:22: error: unknown type name 'off64_t'; did you mean 'off_t'?
3358 | # define Off_t off64_t
|
| 16:12:04 |
| matthewcroughan | Alyssa Ross: O.o (https://github.com/NixOS/nixpkgs/pull/452642#discussion_r2436725816) how do you upstream to perl? | 16:57:10 |
| matthewcroughan | I'm young | 16:57:15 |
| matthewcroughan | Looks like https://github.com/perl5-dbi/dbi actually | 17:00:08 |
 Alyssa Ross | it's not to perl, it's just a perl package | 17:00:09 |
| matthewcroughan | Yeah I meant to the perl ecosystem | 17:00:18 |
| matthewcroughan | like it's not always clear where the sources or appropriate upstream path is | 17:00:33 |
| matthewcroughan | sometimes github, sometimes mailing lists, sometimes nowhere | 17:00:40 |
| matthewcroughan | and since we use mirror:// that further masks it | 17:01:00 |
| Alyssa Ross | looks like they merge PRs in this case | 17:01:12 |
| matthewcroughan | NIce! | 17:01:16 |
| matthewcroughan | * Nice! | 17:01:22 |
| Alyssa Ross | BTW: if something is going to be broken on every musl distro (like this fix), please try to take the fix upstream before working around it in Nixpkgs. If we all do this (and the other distros usually do), it's less work for all of us than if we all have to separately apply the same workarounds downstream. | 17:02:29 |
| matthewcroughan | I can't find a reference to off64_t in their sources on github | 17:02:31 |
| Alyssa Ross | hmm, maybe it got fixed already? | 17:02:42 |
| matthewcroughan | The reason I make the PRs isn't always to get it merged, but to provide a reproducer that allows others to tell me that it should be upstreamed | 17:03:06 |
| Alyssa Ross | presumably the build error shows you were off64_t was used | 17:03:08 |
| matthewcroughan | I'm not as experienced, so I need someone like you to tell me that I need to upstream it | 17:03:14 |
| matthewcroughan | More like a request for comment really | 17:03:39 |
| Alyssa Ross | ah, in that case drafting the PR is a good way to communicate that | 17:03:49 |
| matthewcroughan | Okay I can start doing that | 17:03:56 |
| Alyssa Ross | otherwise there's a risk that somebody merges it without understanding your intention that it not necessarily be merged as is | 17:04:19 |
| Alyssa Ross | thanks for all your efforts btw :) | 17:04:32 |
| matthewcroughan | headpat accepted | 17:04:47 |
| matthewcroughan | Alyssa Ross: Actually it does look like it's the perl core that's broken? | 17:09:44 |
| matthewcroughan | > /nix/store/xi08qryndrv2a2vih9s4n5kzfp8hzn9r-perl-5.40.0/lib/perl5/5.40.0/aarch64-linux-thread-multi/CORE/proto.h:10777:15: error: unknown type name 'off64_t'; did you mean 'off_t'? | 17:09:45 |
| matthewcroughan | that's not coming from DBI, it's coming from perl core, no? | 17:09:52 |
| matthewcroughan | lib/perl5/5.40.0/aarch64-linux-thread-multi/CORE/proto.h | 17:10:06 |
| Alyssa Ross | oh, interesting | 17:12:00 |
| Alyssa Ross | looks like it | 17:12:01 |
